third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h - Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h

Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h b/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h

index b0bdfb43150c92e96a833fecdea82bf09d0e077e..54c99b79f71ce868dfc1a3d43d8010480be500b0 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h

@@ -30,7 +30,7 @@ public:

void voidMethod() override;

bool booleanMethod() override;

void voidMethodBooleanArg(bool boolArg) override;

- void voidMethodSequenceArg(const Vector<RefPtr<TestInterfaceEmpty>>& sequenceArg) override;

+ void voidMethodSequenceArg(const HeapVector<Member<TestInterfaceEmpty>>& sequenceArg) override;

void voidMethodFloatArg(float floatArg) override;

void voidMethodTestInterfaceEmptyArg(TestInterfaceEmpty* testInterfaceEmptyArg) override;

void voidMethodTestInterfaceEmptyStringArg(TestInterfaceEmpty* testInterfaceEmptyArg, const String& stringArg) override;