Convert //ash from scoped_ptr to std::unique_ptr

Convert //ash from scoped_ptr to std::unique_ptr

BUG=554298
Committed: https://crrev.com/a9454747427889f70d14df4646f7f599d00df02d
Cr-Commit-Position: refs/heads/master@{#386019}

[dcheng, 2016-04-08 04:48:49]

dcheng@chromium.org changed reviewers:
+ oshima@chromium.org

[dcheng, 2016-04-08 04:48:52]

This is largely a search and replace. There's probably some IWYU errors (files
that don't include memory when they should and those that do when they
shouldn't), but fixing those is out-of-scope for this conversion work.

[oshima, 2016-04-08 07:09:43]

lgtm

you may ignore these comments.

https://codereview.chromium.org/1867223004/diff/1/ash/accelerators/accelerato...
File ash/accelerators/accelerator_commands_unittest.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/accelerators/accelerato...
ash/accelerators/accelerator_commands_unittest.cc:6: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/ash_touch_exploration_m...
File ash/ash_touch_exploration_manager_chromeos.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/ash_touch_exploration_m...
ash/ash_touch_exploration_manager_chromeos.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/desktop_background/desk...
File ash/desktop_background/desktop_background_view.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/desktop_background/desk...
ash/desktop_background/desktop_background_view.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/dip_unittest.cc
File ash/dip_unittest.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/dip_unittest.cc#newcode6
ash/dip_unittest.cc:6: #include <memory>
not necessary?

https://codereview.chromium.org/1867223004/diff/1/ash/display/cursor_window_c...
File ash/display/cursor_window_controller.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/display/cursor_window_c...
ash/display/cursor_window_controller.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/display/display_animato...
File ash/display/display_animator_chromeos.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/display/display_animato...
ash/display/display_animator_chromeos.h:8: #include <map>
include?

https://codereview.chromium.org/1867223004/diff/1/ash/display/display_color_m...
File ash/display/display_color_manager_chromeos.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/display/display_color_m...
ash/display/display_color_manager_chromeos.h:10: #include <map>
include?

https://codereview.chromium.org/1867223004/diff/1/ash/display/display_configu...
File ash/display/display_configuration_controller.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/display/display_configu...
ash/display/display_configuration_controller.h:7: 
include ?

https://codereview.chromium.org/1867223004/diff/1/ash/display/display_configu...
ash/display/display_configuration_controller.h:12: // * TODO: Forwards display
configuration changed events to UI and API classes.
This should be moved to 32 but I'll take care of it.

https://codereview.chromium.org/1867223004/diff/1/ash/display/display_error_o...
File ash/display/display_error_observer_chromeos.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/display/display_error_o...
ash/display/display_error_observer_chromeos.cc:8: #include <utility>
include?

https://codereview.chromium.org/1867223004/diff/1/ash/display/json_converter.cc
File ash/display/json_converter.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/display/json_converter....
ash/display/json_converter.cc:7: #include <string>
include?

https://codereview.chromium.org/1867223004/diff/1/ash/display/json_converter_...
File ash/display/json_converter_unittest.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/display/json_converter_...
ash/display/json_converter_unittest.cc:5: #include
"ash/display/json_converter.h"
include?

https://codereview.chromium.org/1867223004/diff/1/ash/display/root_window_tra...
File ash/display/root_window_transformers.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/display/root_window_tra...
ash/display/root_window_transformers.cc:8: #include <memory>
not necessary?

https://codereview.chromium.org/1867223004/diff/1/ash/display/root_window_tra...
File ash/display/root_window_transformers_unittest.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/display/root_window_tra...
ash/display/root_window_transformers_unittest.cc:6: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/display/screen_position...
File ash/display/screen_position_controller_unittest.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/display/screen_position...
ash/display/screen_position_controller_unittest.cc:6: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/display/window_tree_hos...
File ash/display/window_tree_host_manager.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/display/window_tree_hos...
ash/display/window_tree_host_manager.cc:6: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/display/window_tree_hos...
File ash/display/window_tree_host_manager_unittest.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/display/window_tree_hos...
ash/display/window_tree_host_manager_unittest.cc:6: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/drag_drop/drag_drop_con...
File ash/drag_drop/drag_drop_controller.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/drag_drop/drag_drop_con...
ash/drag_drop/drag_drop_controller.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/drag_drop/drag_image_vi...
File ash/drag_drop/drag_image_view.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/drag_drop/drag_image_vi...
ash/drag_drop/drag_image_view.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/focus_cycler_unittest.cc
File ash/focus_cycler_unittest.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/focus_cycler_unittest.c...
ash/focus_cycler_unittest.cc:6: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/frame/caption_buttons/f...
File ash/frame/caption_buttons/frame_size_button.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/frame/caption_buttons/f...
ash/frame/caption_buttons/frame_size_button.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/frame/frame_border_hit_...
File ash/frame/frame_border_hit_test_controller.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/frame/frame_border_hit_...
ash/frame/frame_border_hit_test_controller.cc:6: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/host/ash_window_tree_ho...
File ash/host/ash_window_tree_host_platform.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/host/ash_window_tree_ho...
ash/host/ash_window_tree_host_platform.h:6: #define
ASH_HOST_ASH_WINDOW_TREE_HOST_PLATFORM_H_
include?

https://codereview.chromium.org/1867223004/diff/1/ash/keyboard/keyboard_ui_ob...
File ash/keyboard/keyboard_ui_observer.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/keyboard/keyboard_ui_ob...
ash/keyboard/keyboard_ui_observer.h:8: #include <memory>
not necessary?

https://codereview.chromium.org/1867223004/diff/1/ash/magnifier/magnification...
File ash/magnifier/magnification_controller.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/magnifier/magnification...
ash/magnifier/magnification_controller.cc:7: #include <utility>
include?

https://codereview.chromium.org/1867223004/diff/1/ash/magnifier/magnification...
File ash/magnifier/magnification_controller.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/magnifier/magnification...
ash/magnifier/magnification_controller.h:8: #include <memory>
ditto

https://codereview.chromium.org/1867223004/diff/1/ash/mus/keyboard_ui_mus.h
File ash/mus/keyboard_ui_mus.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/mus/keyboard_ui_mus.h#n...
ash/mus/keyboard_ui_mus.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/mus/shelf_delegate_mus.cc
File ash/mus/shelf_delegate_mus.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/mus/shelf_delegate_mus....
ash/mus/shelf_delegate_mus.cc:6: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/shelf/scoped_observer_w...
File ash/shelf/scoped_observer_with_duplicated_sources_unittest.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/shelf/scoped_observer_w...
ash/shelf/scoped_observer_with_duplicated_sources_unittest.cc:7: #include
<memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/shelf/shelf.h
File ash/shelf/shelf.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/shelf/shelf.h#newcode8
ash/shelf/shelf.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/shelf/shelf_layout_mana...
File ash/shelf/shelf_layout_manager.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/shelf/shelf_layout_mana...
ash/shelf/shelf_layout_manager.h:8: #include <vector>
include?

https://codereview.chromium.org/1867223004/diff/1/ash/shelf/shelf_view.h
File ash/shelf/shelf_view.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/shelf/shelf_view.h#newc...
ash/shelf/shelf_view.h:10: #include <vector>
include?

https://codereview.chromium.org/1867223004/diff/1/ash/shelf/shelf_widget.h
File ash/shelf/shelf_widget.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/shelf/shelf_widget.h#ne...
ash/shelf/shelf_widget.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/shelf/shelf_window_watc...
File ash/shelf/shelf_window_watcher.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/shelf/shelf_window_watc...
ash/shelf/shelf_window_watcher.h:10: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/shell/app_list.cc
File ash/shell/app_list.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/shell/app_list.cc#newcode8
ash/shell/app_list.cc:8: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/shell/shell_delegate_im...
File ash/shell/shell_delegate_impl.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/shell/shell_delegate_im...
ash/shell/shell_delegate_impl.h:8: #include <string>
include

https://codereview.chromium.org/1867223004/diff/1/ash/shell/window_type_launc...
File ash/shell/window_type_launcher.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/shell/window_type_launc...
ash/shell/window_type_launcher.h:7: 
include

https://codereview.chromium.org/1867223004/diff/1/ash/system/chromeos/audio/t...
File ash/system/chromeos/audio/tray_audio_chromeos.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/chromeos/audio/t...
ash/system/chromeos/audio/tray_audio_chromeos.h:10: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/system/chromeos/brightn...
File ash/system/chromeos/brightness/tray_brightness_unittest.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/chromeos/brightn...
ash/system/chromeos/brightness/tray_brightness_unittest.cc:6: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/system/chromeos/power/b...
File ash/system/chromeos/power/battery_notification.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/chromeos/power/b...
ash/system/chromeos/power/battery_notification.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/system/chromeos/power/t...
File ash/system/chromeos/power/tray_power.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/chromeos/power/t...
ash/system/chromeos/power/tray_power.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/system/chromeos/session...
File ash/system/chromeos/session/tray_session_length_limit.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/chromeos/session...
ash/system/chromeos/session/tray_session_length_limit.cc:8: #include <utility>
include?

https://codereview.chromium.org/1867223004/diff/1/ash/system/chromeos/tray_di...
File ash/system/chromeos/tray_display.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/chromeos/tray_di...
ash/system/chromeos/tray_display.cc:8: #include <vector>
include?

https://codereview.chromium.org/1867223004/diff/1/ash/system/status_area_widg...
File ash/system/status_area_widget_delegate.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/status_area_widg...
ash/system/status_area_widget_delegate.cc:7: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/system/toast/toast_mana...
File ash/system/toast/toast_manager.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/toast/toast_mana...
ash/system/toast/toast_manager.h:9: #include <string>
include?

https://codereview.chromium.org/1867223004/diff/1/ash/system/tray/tray_backgr...
File ash/system/tray/tray_background_view.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/tray/tray_backgr...
ash/system/tray/tray_background_view.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/system/tray/tray_bubble...
File ash/system/tray/tray_bubble_wrapper.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/tray/tray_bubble...
ash/system/tray/tray_bubble_wrapper.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/system/tray/tray_item_v...
File ash/system/tray/tray_item_view.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/tray/tray_item_v...
ash/system/tray/tray_item_view.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/system/user/user_view.h
File ash/system/user/user_view.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/user/user_view.h...
ash/system/user/user_view.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/system/win/audio/tray_a...
File ash/system/win/audio/tray_audio_win.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/win/audio/tray_a...
ash/system/win/audio/tray_audio_win.cc:6: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/system/win/audio/tray_a...
File ash/system/win/audio/tray_audio_win.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/system/win/audio/tray_a...
ash/system/win/audio/tray_audio_win.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/test/ash_test_base.h
File ash/test/ash_test_base.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/test/ash_test_base.h#ne...
ash/test/ash_test_base.h:10: #include <string>
#include?

https://codereview.chromium.org/1867223004/diff/1/ash/test/display_manager_te...
File ash/test/display_manager_test_api.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/test/display_manager_te...
ash/test/display_manager_test_api.h:11: #include <vector>
include?

https://codereview.chromium.org/1867223004/diff/1/ash/test/mirror_window_test...
File ash/test/mirror_window_test_api.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/test/mirror_window_test...
ash/test/mirror_window_test_api.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/test/user_metrics_recor...
File ash/test/user_metrics_recorder_test_api.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/test/user_metrics_recor...
ash/test/user_metrics_recorder_test_api.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/drag_details.h
File ash/wm/drag_details.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/drag_details.h#newcode8
ash/wm/drag_details.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/gestures/long_press_...
File ash/wm/gestures/long_press_affordance_handler.cc (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/gestures/long_press_...
ash/wm/gestures/long_press_affordance_handler.cc:6: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/gestures/shelf_gestu...
File ash/wm/gestures/shelf_gesture_handler.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/gestures/shelf_gestu...
ash/wm/gestures/shelf_gesture_handler.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/immersive_fullscreen...
File ash/wm/immersive_fullscreen_controller.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/immersive_fullscreen...
ash/wm/immersive_fullscreen_controller.h:8: #include <vector>
include?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/lock_layout_manager.h
File ash/wm/lock_layout_manager.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/lock_layout_manager....
ash/wm/lock_layout_manager.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/maximize_mode/maximi...
File ash/wm/maximize_mode/maximize_mode_window_state.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/maximize_mode/maximi...
ash/wm/maximize_mode/maximize_mode_window_state.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/mru_window_tracker.h
File ash/wm/mru_window_tracker.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/mru_window_tracker.h...
ash/wm/mru_window_tracker.h:9: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/overview/scoped_over...
File ash/wm/overview/scoped_overview_animation_settings.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/overview/scoped_over...
ash/wm/overview/scoped_overview_animation_settings.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/overview/scoped_tran...
File ash/wm/overview/scoped_transform_overview_window.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/overview/scoped_tran...
ash/wm/overview/scoped_transform_overview_window.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/panels/panel_frame_v...
File ash/wm/panels/panel_frame_view.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/panels/panel_frame_v...
ash/wm/panels/panel_frame_view.h:7: 
include ?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/panels/panel_window_...
File ash/wm/panels/panel_window_resizer.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/panels/panel_window_...
ash/wm/panels/panel_window_resizer.h:7: 
include?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/root_window_layout_m...
File ash/wm/root_window_layout_manager.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/root_window_layout_m...
ash/wm/root_window_layout_manager.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/screen_dimmer.h
File ash/wm/screen_dimmer.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/screen_dimmer.h#newc...
ash/wm/screen_dimmer.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/stacking_controller.h
File ash/wm/stacking_controller.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/stacking_controller....
ash/wm/stacking_controller.h:8: #include <memory>
remove this?

https://codereview.chromium.org/1867223004/diff/1/ash/wm/system_modal_contain...
File ash/wm/system_modal_container_layout_manager.h (right):

https://codereview.chromium.org/1867223004/diff/1/ash/wm/system_modal_contain...
ash/wm/system_modal_container_layout_manager.h:8: #include <memory>
remove this?

[dcheng, 2016-04-08 07:51:52]

Addressed comments. Rietveld really needs a way for reviewers to suggest edits
that the patch owner can apply by clicking a button =)

[dcheng, 2016-04-08 07:52:01]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-08 07:52:02]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1867223004/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-04-08 07:52:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867223004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867223004/20001

[commit-bot: I haz the power, 2016-04-08 08:41:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-08 08:43:13]

Description was changed from

==========
Convert //ash from scoped_ptr to std::unique_ptr

BUG=554298
==========

to

==========
Convert //ash from scoped_ptr to std::unique_ptr

BUG=554298

Committed: https://crrev.com/a9454747427889f70d14df4646f7f599d00df02d
Cr-Commit-Position: refs/heads/master@{#386019}
==========

[commit-bot: I haz the power, 2016-04-08 08:43:15]

Patchset 2 (id:??) landed as
https://crrev.com/a9454747427889f70d14df4646f7f599d00df02d
Cr-Commit-Position: refs/heads/master@{#386019}