ash/shell/window_type_launcher.cc - Issue 1867223004: Convert //ash from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell/window_type_launcher.cc

Issue 1867223004: Convert //ash from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shell/window_type_launcher.cc

diff --git a/ash/shell/window_type_launcher.cc b/ash/shell/window_type_launcher.cc

index 48058910b433dd12b8e160f19cfef250eefb4aa2..5b113d8ddbd00310acc4b4ca7ad1761d462fe90b 100644

--- a/ash/shell/window_type_launcher.cc

+++ b/ash/shell/window_type_launcher.cc

@@ -312,7 +312,7 @@ void WindowTypeLauncher::ButtonPressed(views::Button* sender,

} else if (sender == show_hide_window_button_) {

NonModalTransient::ToggleNonModalTransient(GetWidget()->GetNativeView());

} else if (sender == show_web_notification_) {

- scoped_ptr<message_center::Notification> notification;

+ std::unique_ptr<message_center::Notification> notification;

notification.reset(new message_center::Notification(

message_center::NOTIFICATION_TYPE_SIMPLE, "id0",

base::ASCIIToUTF16("Test Shell Web Notification"),

« no previous file with comments | « ash/shell/window_type_launcher.h ('k') | ash/shell/window_watcher.h » ('j') | no next file with comments »