ash/system/chromeos/network/network_state_list_detailed_view.cc - Issue 1867223004: Convert //ash from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/chromeos/network/network_state_list_detailed_view.cc

Issue 1867223004: Convert //ash from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/system/chromeos/network/network_state_list_detailed_view.cc

diff --git a/ash/system/chromeos/network/network_state_list_detailed_view.cc b/ash/system/chromeos/network/network_state_list_detailed_view.cc

index 1885903a265c54600c675fca27c602762063d57c..b03c12acb24906ac16bc9e6ab55bb38ce6d8cf09 100644

--- a/ash/system/chromeos/network/network_state_list_detailed_view.cc

+++ b/ash/system/chromeos/network/network_state_list_detailed_view.cc

@@ -796,7 +796,7 @@ views::View* NetworkStateListDetailedView::CreateControlledByExtensionView(

->GetNetworkingConfigDelegate();

if (!networking_config_delegate)

return nullptr;

- scoped_ptr<const ash::NetworkingConfigDelegate::ExtensionInfo>

+ std::unique_ptr<const ash::NetworkingConfigDelegate::ExtensionInfo>

extension_info = networking_config_delegate->LookUpExtensionForNetwork(

info.service_path);

if (!extension_info)