Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: ash/display/json_converter_unittest.cc

Issue 1867223004: Convert //ash from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/display/json_converter.h" 5 #include "ash/display/json_converter.h"
oshima 2016/04/08 07:09:40 include?
6 6
7 #include "base/json/json_reader.h" 7 #include "base/json/json_reader.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "ui/display/manager/display_layout.h" 10 #include "ui/display/manager/display_layout.h"
11 11
12 namespace ash { 12 namespace ash {
13 13
14 TEST(JsonConverterTest, JsonFromToDisplayLayout) { 14 TEST(JsonConverterTest, JsonFromToDisplayLayout) {
15 display::DisplayLayout layout; 15 display::DisplayLayout layout;
(...skipping 26 matching lines...) Expand all
42 " \"offset\": 0\n" 42 " \"offset\": 0\n"
43 " },{\n" 43 " },{\n"
44 " \"display_id\": \"3\",\n" 44 " \"display_id\": \"3\",\n"
45 " \"parent_display_id\": \"2\",\n" 45 " \"parent_display_id\": \"2\",\n"
46 " \"position\": \"left\",\n" 46 " \"position\": \"left\",\n"
47 " \"offset\": 30\n" 47 " \"offset\": 30\n"
48 " }]\n" 48 " }]\n"
49 "}"; 49 "}";
50 int error_code = 0, error_line, error_column; 50 int error_code = 0, error_line, error_column;
51 std::string error_msg; 51 std::string error_msg;
52 scoped_ptr<base::Value> read_value(base::JSONReader::ReadAndReturnError( 52 std::unique_ptr<base::Value> read_value(base::JSONReader::ReadAndReturnError(
53 data, 0, &error_code, &error_msg, &error_line, &error_column)); 53 data, 0, &error_code, &error_msg, &error_line, &error_column));
54 ASSERT_EQ(0, error_code) << error_msg << " at " << error_line << ":" 54 ASSERT_EQ(0, error_code) << error_msg << " at " << error_line << ":"
55 << error_column; 55 << error_column;
56 EXPECT_TRUE(value.Equals(read_value.get())); 56 EXPECT_TRUE(value.Equals(read_value.get()));
57 57
58 display::DisplayLayout read_layout; 58 display::DisplayLayout read_layout;
59 EXPECT_TRUE(JsonToDisplayLayout(*read_value, &read_layout)); 59 EXPECT_TRUE(JsonToDisplayLayout(*read_value, &read_layout));
60 EXPECT_EQ(read_layout.mirrored, layout.mirrored); 60 EXPECT_EQ(read_layout.mirrored, layout.mirrored);
61 EXPECT_EQ(read_layout.primary_id, layout.primary_id); 61 EXPECT_EQ(read_layout.primary_id, layout.primary_id);
62 EXPECT_EQ(read_layout.default_unified, layout.default_unified); 62 EXPECT_EQ(read_layout.default_unified, layout.default_unified);
63 EXPECT_TRUE(read_layout.HasSamePlacementList(layout)); 63 EXPECT_TRUE(read_layout.HasSamePlacementList(layout));
64 } 64 }
65 65
66 TEST(JsonConverterTest, OldJsonToDisplayLayout) { 66 TEST(JsonConverterTest, OldJsonToDisplayLayout) {
67 const char data[] = 67 const char data[] =
68 "{\n" 68 "{\n"
69 " \"primary-id\": \"1\",\n" 69 " \"primary-id\": \"1\",\n"
70 " \"mirrored\": true,\n" 70 " \"mirrored\": true,\n"
71 " \"default_unified\": false,\n" 71 " \"default_unified\": false,\n"
72 " \"position\": \"bottom\",\n" 72 " \"position\": \"bottom\",\n"
73 " \"offset\": 20\n" 73 " \"offset\": 20\n"
74 "}"; 74 "}";
75 int error_code = 0, error_line, error_column; 75 int error_code = 0, error_line, error_column;
76 std::string error_msg; 76 std::string error_msg;
77 scoped_ptr<base::Value> read_value(base::JSONReader::ReadAndReturnError( 77 std::unique_ptr<base::Value> read_value(base::JSONReader::ReadAndReturnError(
78 data, 0, &error_code, &error_msg, &error_line, &error_column)); 78 data, 0, &error_code, &error_msg, &error_line, &error_column));
79 ASSERT_EQ(0, error_code) << error_msg << " at " << error_line << ":" 79 ASSERT_EQ(0, error_code) << error_msg << " at " << error_line << ":"
80 << error_column; 80 << error_column;
81 81
82 display::DisplayLayout read_layout; 82 display::DisplayLayout read_layout;
83 EXPECT_TRUE(JsonToDisplayLayout(*read_value, &read_layout)); 83 EXPECT_TRUE(JsonToDisplayLayout(*read_value, &read_layout));
84 EXPECT_EQ(true, read_layout.mirrored); 84 EXPECT_EQ(true, read_layout.mirrored);
85 EXPECT_EQ(1, read_layout.primary_id); 85 EXPECT_EQ(1, read_layout.primary_id);
86 EXPECT_EQ(false, read_layout.default_unified); 86 EXPECT_EQ(false, read_layout.default_unified);
87 ASSERT_EQ(1u, read_layout.placement_list.size()); 87 ASSERT_EQ(1u, read_layout.placement_list.size());
88 EXPECT_EQ(display::DisplayPlacement::BOTTOM, 88 EXPECT_EQ(display::DisplayPlacement::BOTTOM,
89 read_layout.placement_list[0].position); 89 read_layout.placement_list[0].position);
90 EXPECT_EQ(20, read_layout.placement_list[0].offset); 90 EXPECT_EQ(20, read_layout.placement_list[0].offset);
91 } 91 }
92 92
93 } // namespace ash 93 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698