Use std::vector as internal storage for CPDF_Array

Use std::vector as internal storage for CPDF_Array

Replace the usage of CFX_ArrayTemplate inside CPDF_Array, which
has non-standard APIs such as GetSize() returns int.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/e1aebd43b0c75133f94f8b141b33d12e2e715524

[Wei Li, 2016-04-08 00:08:06]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-04-08 00:08:15]

Patchset #1 (id:20001) has been deleted

[Wei Li, 2016-04-08 06:04:47]

Patchset #1 (id:40001) has been deleted

[Wei Li, 2016-04-08 19:27:09]

Patchset #1 (id:60001) has been deleted

[Wei Li, 2016-04-08 19:39:31]

weili@chromium.org changed reviewers:
+ tsepez@chromium.org

[Wei Li, 2016-04-08 19:39:32]

Continue tackling the signed/unsigned and data types problem. PTAL, thanks.

[Tom Sepez, 2016-04-08 20:13:53]

LGTM with suggestions for followup

https://codereview.chromium.org/1867183002/diff/80001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_array.cpp (right):

https://codereview.chromium.org/1867183002/diff/80001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_array.cpp:18: for (auto& it : m_Objects) {
Now that this is a STL array, we can use 
std::vector<std::unique_ptr<CPDF_Object, ReleaseDeleter<CPDF_Object>>> m_Objects


and this goes away

https://codereview.chromium.org/1867183002/diff/80001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/include/cpdf_array.h (right):

https://codereview.chromium.org/1867183002/diff/80001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/include/cpdf_array.h:64: std::vector<CPDF_Object*>
m_Objects;
Now that we've done this, we might want to add to the public section:

using iterator = std::vector<CPDF_Object*>::iterator;
using const_iterator = std::vector<CPDF_Object*>::const_iterator;

iterator begin() { return m_Objects.begin(); }
iterator end() { return m_Objects.end(); }

const_iterator begin() const { return m_Objects.begin(); }
const_iterator end() const { return m_Objects.end(); }


then callers should be able do to something like

  for (CPDF_Object* pObj : *pArray) { ... }

[Wei Li, 2016-04-11 16:42:16]

Thanks, will change those in the next CL with a unit test.

[Wei Li, 2016-04-11 17:02:15]

Description was changed from

==========
Use std::vector as internal storage for CPDF_Array

Replace the usage of CFX_ArrayTemplate inside CPDF_Array, which
has non-standard APIs such as GetSize() returns int.
==========

to

==========
Use std::vector as internal storage for CPDF_Array

Replace the usage of CFX_ArrayTemplate inside CPDF_Array, which
has non-standard APIs such as GetSize() returns int.

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/e1aebd43b0c75133f94f8b141b33d12e2e71...
==========

[Wei Li, 2016-04-11 17:02:16]

Committed patchset #1 (id:80001) manually as
e1aebd43b0c75133f94f8b141b33d12e2e715524 (presubmit successful).

[Oliver Chang, 2016-04-11 21:54:39]

ochang@chromium.org changed reviewers:
+ ochang@chromium.org

[Oliver Chang, 2016-04-11 21:54:40]

Wei, could you please fix this compilation error? (And if you have time, figure
out why things are breaking during rolls and not on our bots -- I suspect
there's a GN/GYP discrepancy).

https://codereview.chromium.org/1867183002/diff/80001/core/fpdfdoc/cpvt_gener...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/1867183002/diff/80001/core/fpdfdoc/cpvt_gener...
core/fpdfdoc/cpvt_generateap.cpp:360: for (size_t i = nTop, sz =
pOpts->GetCount(); i < sz; i++) {
It looks like this change is causing this:
https://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng...


e:\b\build\slave\win_gn\build\src\third_party\pdfium\core\fpdfdoc\cpvt_generateap.cpp(373):
error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_gn\build\src\third_party\pdfium\core\fpdfdoc\cpvt_generateap.cpp(373):
warning C4389: '==': signed/unsigned mismatch

[Oliver Chang, 2016-04-11 22:01:29]

https://codereview.chromium.org/1867183002/diff/80001/core/fpdfdoc/cpvt_gener...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/1867183002/diff/80001/core/fpdfdoc/cpvt_gener...
core/fpdfdoc/cpvt_generateap.cpp:360: for (size_t i = nTop, sz =
pOpts->GetCount(); i < sz; i++) {
On 2016/04/11 21:54:40, Oliver Chang wrote:
> It looks like this change is causing this:
>
https://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng...
> 
> 
>
e:\b\build\slave\win_gn\build\src\third_party\pdfium\core\fpdfdoc\cpvt_generateap.cpp(373):
> error C2220: warning treated as error - no 'object' file generated
>
e:\b\build\slave\win_gn\build\src\third_party\pdfium\core\fpdfdoc\cpvt_generateap.cpp(373):
> warning C4389: '==': signed/unsigned mismatch

Oh, it might be 'WarningLevel': '3',. Let's see what happens if we flip this to
4...