Use std::vector as internal storage for CPDF_Array

core/fpdfdoc/cpvt_generateap.cpp

Index: core/fpdfdoc/cpvt_generateap.cpp
diff --git a/core/fpdfdoc/cpvt_generateap.cpp b/core/fpdfdoc/cpvt_generateap.cpp
index ee99becaeecb4e462214fa8f6b9d54806f6c0a41..9b61941afdef2a89fbca4a2d3292f0eb46793862 100644
--- a/core/fpdfdoc/cpvt_generateap.cpp
+++ b/core/fpdfdoc/cpvt_generateap.cpp
@@ -357,7 +357,7 @@ FX_BOOL GenerateWidgetAP(CPDF_Document* pDoc,
       CFX_ByteTextBuf sBody;
       if (pOpts) {
         FX_FLOAT fy = rcBody.top;
-        for (int32_t i = nTop, sz = pOpts->GetCount(); i < sz; i++) {
+        for (size_t i = nTop, sz = pOpts->GetCount(); i < sz; i++) {

[Oliver Chang, 2016/04/11 21:54:40]

It looks like this change is causing this:
https://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng...


e:\b\build\slave\win_gn\build\src\third_party\pdfium\core\fpdfdoc\cpvt_generateap.cpp(373):
error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_gn\build\src\third_party\pdfium\core\fpdfdoc\cpvt_generateap.cpp(373):
warning C4389: '==': signed/unsigned mismatch

[Oliver Chang, 2016/04/11 22:01:29]

Oh, it might be 'WarningLevel': '3',. Let's see what happens if we flip this to
4...

           if (IsFloatSmaller(fy, rcBody.bottom))
             break;
 
@@ -370,7 +370,7 @@ FX_BOOL GenerateWidgetAP(CPDF_Document* pDoc,
 
             FX_BOOL bSelected = FALSE;
             if (pSels) {
-              for (uint32_t s = 0, ssz = pSels->GetCount(); s < ssz; s++) {
+              for (size_t s = 0, ssz = pSels->GetCount(); s < ssz; s++) {
                 if (i == pSels->GetIntegerAt(s)) {
                   bSelected = TRUE;
                   break;