core/fpdfdoc/doc_tagged.cpp - Issue 1867183002: Use std::vector as internal storage for CPDF_Array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/doc_tagged.cpp

Issue 1867183002: Use std::vector as internal storage for CPDF_Array (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/doc_tagged.cpp

diff --git a/core/fpdfdoc/doc_tagged.cpp b/core/fpdfdoc/doc_tagged.cpp

index 94c143d51c2c81e0e9be25abd560f7601170ae2b..bf2b941e5e30b459fd6c8ab948c24c260e4ad91d 100644

--- a/core/fpdfdoc/doc_tagged.cpp

+++ b/core/fpdfdoc/doc_tagged.cpp

@@ -70,7 +70,7 @@ void CPDF_StructTreeImpl::LoadDocTree() {

if (!pArray)

return;

- for (uint32_t i = 0; i < pArray->GetCount(); i++) {

+ for (size_t i = 0; i < pArray->GetCount(); i++) {

CPDF_Dictionary* pKid = pArray->GetDictAt(i);

CPDF_StructElementImpl* pStructElementImpl =

new CPDF_StructElementImpl(this, nullptr, pKid);