fpdfsdk/fpdfppo.cpp - Issue 1867183002: Use std::vector as internal storage for CPDF_Array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfppo.cpp

Issue 1867183002: Use std::vector as internal storage for CPDF_Array (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfppo.cpp

diff --git a/fpdfsdk/fpdfppo.cpp b/fpdfsdk/fpdfppo.cpp

index 21d8c7d9aeb9526767f2f43ed9d1ae765dc53566..8ada7aacb1c236b554e2792ff1ea880fd46757ac 100644

--- a/fpdfsdk/fpdfppo.cpp

+++ b/fpdfsdk/fpdfppo.cpp

@@ -238,8 +238,7 @@ FX_BOOL CPDF_PageOrganizer::UpdateReference(CPDF_Object* pObj,

}

case CPDF_Object::ARRAY: {

CPDF_Array* pArray = pObj->AsArray();

- uint32_t count = pArray->GetCount();

- for (uint32_t i = 0; i < count; ++i) {

+ for (size_t i = 0; i < pArray->GetCount(); ++i) {

CPDF_Object* pNextObj = pArray->GetObjectAt(i);

if (!pNextObj)

return FALSE;