fpdfsdk/fsdk_actionhandler.cpp - Issue 1867183002: Use std::vector as internal storage for CPDF_Array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fsdk_actionhandler.cpp

Issue 1867183002: Use std::vector as internal storage for CPDF_Array (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fsdk_actionhandler.cpp

diff --git a/fpdfsdk/fsdk_actionhandler.cpp b/fpdfsdk/fsdk_actionhandler.cpp

index ebcaf354ada0e818106ea087a95f75f62f8add5f..0bbdbab1376493d683df56b6be248e55db7fe540 100644

--- a/fpdfsdk/fsdk_actionhandler.cpp

+++ b/fpdfsdk/fsdk_actionhandler.cpp

@@ -439,7 +439,7 @@ void CPDFSDK_ActionHandler::DoAction_GoTo(CPDFSDK_Document* pDocument,

if (pMyArray) {

pPosAry = new float[pMyArray->GetCount()];

int j = 0;

- for (int i = 2; i < (int)pMyArray->GetCount(); i++) {

+ for (size_t i = 2; i < pMyArray->GetCount(); i++) {

pPosAry[j++] = pMyArray->GetFloatAt(i);

}

sizeOfAry = j;