Use std::vector as internal storage for CPDF_Array

core/fpdfdoc/cpvt_generateap.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfdoc/cpvt_generateap.h"
 
 #include "core/fpdfapi/fpdf_font/include/cpdf_font.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h"
@@ skipping 339 matching lines @@
                               : nullptr;
       CPDF_Array* pSels = FPDF_GetFieldAttr(pAnnotDict, "I")
                               ? FPDF_GetFieldAttr(pAnnotDict, "I")->GetArray()
                               : nullptr;
       int32_t nTop = FPDF_GetFieldAttr(pAnnotDict, "TI")
                          ? FPDF_GetFieldAttr(pAnnotDict, "TI")->GetInteger()
                          : 0;
       CFX_ByteTextBuf sBody;
       if (pOpts) {
         FX_FLOAT fy = rcBody.top;
-        for (int32_t i = nTop, sz = pOpts->GetCount(); i < sz; i++) {
+        for (size_t i = nTop, sz = pOpts->GetCount(); i < sz; i++) {

[Oliver Chang, 2016/04/11 21:54:40]

It looks like this change is causing this:
https://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng...


e:\b\build\slave\win_gn\build\src\third_party\pdfium\core\fpdfdoc\cpvt_generateap.cpp(373):
error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_gn\build\src\third_party\pdfium\core\fpdfdoc\cpvt_generateap.cpp(373):
warning C4389: '==': signed/unsigned mismatch

[Oliver Chang, 2016/04/11 22:01:29]

Oh, it might be 'WarningLevel': '3',. Let's see what happens if we flip this to
4...

           if (IsFloatSmaller(fy, rcBody.bottom))
             break;
 
           if (CPDF_Object* pOpt = pOpts->GetDirectObjectAt(i)) {
             CFX_WideString swItem;
             if (pOpt->IsString())
               swItem = pOpt->GetUnicodeText();
             else if (CPDF_Array* pArray = pOpt->AsArray())
               swItem = pArray->GetDirectObjectAt(1)->GetUnicodeText();
 
             FX_BOOL bSelected = FALSE;
             if (pSels) {
-              for (uint32_t s = 0, ssz = pSels->GetCount(); s < ssz; s++) {
+              for (size_t s = 0, ssz = pSels->GetCount(); s < ssz; s++) {
                 if (i == pSels->GetIntegerAt(s)) {
                   bSelected = TRUE;
                   break;
                 }
               }
             }
             CPDF_VariableText vt;
             vt.SetProvider(&prd);
             vt.SetPlateRect(
                 CFX_FloatRect(rcBody.left, 0.0f, rcBody.right, 0.0f));
@@ skipping 379 matching lines @@
                                                  int32_t nFontIndex,
                                                  FX_FLOAT fFontSize) {
   CFX_ByteTextBuf sRet;
   if (pFontMap) {
     CFX_ByteString sFontAlias = pFontMap->GetPDFFontAlias(nFontIndex);
     if (sFontAlias.GetLength() > 0 && fFontSize > 0)
       sRet << "/" << sFontAlias << " " << fFontSize << " Tf\n";
   }
   return sRet.GetByteString();
 }