fpdfsdk/pdfwindow/PWL_Icon.cpp - Issue 1867183002: Use std::vector as internal storage for CPDF_Array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/pdfwindow/PWL_Icon.cpp

Issue 1867183002: Use std::vector as internal storage for CPDF_Array (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/pdfwindow/PWL_Icon.cpp

diff --git a/fpdfsdk/pdfwindow/PWL_Icon.cpp b/fpdfsdk/pdfwindow/PWL_Icon.cpp

index 69f9e599daf850e208b3f8ba35cf8b7baf8d8ed6..5e9a4000241387cd63c3509f7b3e1247a9f7b026 100644

--- a/fpdfsdk/pdfwindow/PWL_Icon.cpp

+++ b/fpdfsdk/pdfwindow/PWL_Icon.cpp

@@ -133,7 +133,7 @@ void CPWL_Icon::GetIconPosition(FX_FLOAT& fLeft, FX_FLOAT& fBottom) {

CPDF_Array* pA =

m_pIconFit->GetDict() ? m_pIconFit->GetDict()->GetArrayBy("A") : NULL;

if (pA) {

- uint32_t dwCount = pA->GetCount();

+ size_t dwCount = pA->GetCount();

if (dwCount > 0)

fLeft = pA->GetNumberAt(0);

if (dwCount > 1)