Use std::vector as internal storage for CPDF_Array

fpdfsdk/fpdfdoc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "public/fpdf_doc.h"
 
 #include <set>
 
@@ skipping 268 matching lines @@
                                                int* startPos,
                                                FPDF_LINK* linkAnnot) {
   if (!startPos || !linkAnnot)
     return FALSE;
   CPDF_Page* pPage = CPDFPageFromFPDFPage(page);
   if (!pPage || !pPage->m_pFormDict)
     return FALSE;
   CPDF_Array* pAnnots = pPage->m_pFormDict->GetArrayBy("Annots");
   if (!pAnnots)
     return FALSE;
-  for (int i = *startPos; i < (int)pAnnots->GetCount(); i++) {
+  for (size_t i = *startPos; i < pAnnots->GetCount(); i++) {
     CPDF_Dictionary* pDict =
         ToDictionary(static_cast<CPDF_Object*>(pAnnots->GetDirectObjectAt(i)));
     if (!pDict)
       continue;
     if (pDict->GetStringBy("Subtype") == "Link") {
-      *startPos = i + 1;
-      *linkAnnot = (FPDF_LINK)pDict;
+      *startPos = static_cast<int>(i + 1);
+      *linkAnnot = static_cast<FPDF_LINK>(pDict);
       return TRUE;
     }
   }
   return FALSE;
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDFLink_GetAnnotRect(FPDF_LINK linkAnnot,
                                                   FS_RECTF* rect) {
   if (!linkAnnot || !rect)
     return FALSE;
   CPDF_Dictionary* pAnnotDict =
       ToDictionary(static_cast<CPDF_Object*>(linkAnnot));
   CFX_FloatRect rt = pAnnotDict->GetRectBy("Rect");
   rect->left = rt.left;
   rect->bottom = rt.bottom;
   rect->right = rt.right;
   rect->top = rt.top;
   return TRUE;
 }
 
 DLLEXPORT int STDCALL FPDFLink_CountQuadPoints(FPDF_LINK linkAnnot) {
   if (!linkAnnot)
     return 0;
   CPDF_Dictionary* pAnnotDict =
       ToDictionary(static_cast<CPDF_Object*>(linkAnnot));
   CPDF_Array* pArray = pAnnotDict->GetArrayBy("QuadPoints");
   if (!pArray)
     return 0;
-  return pArray->GetCount() / 8;
+  return static_cast<int>(pArray->GetCount() / 8);
 }
 
 DLLEXPORT FPDF_BOOL STDCALL FPDFLink_GetQuadPoints(FPDF_LINK linkAnnot,
                                                    int quadIndex,
                                                    FS_QUADPOINTSF* quadPoints) {
   if (!linkAnnot || !quadPoints)
     return FALSE;
   CPDF_Dictionary* pAnnotDict =
       ToDictionary(static_cast<CPDF_Object*>(linkAnnot));
   CPDF_Array* pArray = pAnnotDict->GetArrayBy("QuadPoints");
   if (pArray) {
-    if (quadIndex < 0 || quadIndex >= (int)pArray->GetCount() / 8 ||
-        ((quadIndex * 8 + 7) >= (int)pArray->GetCount()))
+    if (quadIndex < 0 ||
+        static_cast<size_t>(quadIndex) >= pArray->GetCount() / 8 ||
+        (static_cast<size_t>(quadIndex * 8 + 7) >= pArray->GetCount()))
       return FALSE;
     quadPoints->x1 = pArray->GetNumberAt(quadIndex * 8);
     quadPoints->y1 = pArray->GetNumberAt(quadIndex * 8 + 1);
     quadPoints->x2 = pArray->GetNumberAt(quadIndex * 8 + 2);
     quadPoints->y2 = pArray->GetNumberAt(quadIndex * 8 + 3);
     quadPoints->x3 = pArray->GetNumberAt(quadIndex * 8 + 4);
     quadPoints->y3 = pArray->GetNumberAt(quadIndex * 8 + 5);
     quadPoints->x4 = pArray->GetNumberAt(quadIndex * 8 + 6);
     quadPoints->y4 = pArray->GetNumberAt(quadIndex * 8 + 7);
     return TRUE;
@@ skipping 15 matching lines @@
     return 0;
   CFX_WideString text = pInfo->GetUnicodeTextBy(tag);
   // Use UTF-16LE encoding
   CFX_ByteString encodedText = text.UTF16LE_Encode();
   unsigned long len = encodedText.GetLength();
   if (buffer && buflen >= len) {
     FXSYS_memcpy(buffer, encodedText.c_str(), len);
   }
   return len;
 }