core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp - Issue 1867183002: Use std::vector as internal storage for CPDF_Array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

Issue 1867183002: Use std::vector as internal storage for CPDF_Array (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

diff --git a/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp b/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

index d70c04c6904d8edcb89f30422d6cc329712bb2ef..31d0beb7f6d2d5758ca883cf62c0366a6650b766 100644

--- a/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

+++ b/core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

@@ -1033,8 +1033,7 @@ static int InsertDeletePDFPage(CPDF_Document* pDoc,

if (!pKidList) {

return -1;

}

- int nKids = pKidList->GetCount();

- for (int i = 0; i < nKids; i++) {

+ for (size_t i = 0; i < pKidList->GetCount(); i++) {

CPDF_Dictionary* pKid = pKidList->GetDictAt(i);

if (pKid->GetStringBy("Type") == "Page") {

if (nPagesToGo == 0) {