core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp - Issue 1867183002: Use std::vector as internal storage for CPDF_Array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

Issue 1867183002: Use std::vector as internal storage for CPDF_Array (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

diff --git a/core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp b/core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

index 31e7388bd73c0a012355ff368e8160f03cbbf54e..bfd0de44b6d8a53e1469d4a1f4a5d6508246107d 100644

--- a/core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

+++ b/core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

@@ -179,7 +179,7 @@ CFX_ByteTextBuf& operator<<(CFX_ByteTextBuf& buf, const CPDF_Object* pObj) {

case CPDF_Object::ARRAY: {

const CPDF_Array* p = pObj->AsArray();

buf << "[";

- for (uint32_t i = 0; i < p->GetCount(); i++) {

+ for (size_t i = 0; i < p->GetCount(); i++) {

CPDF_Object* pElement = p->GetObjectAt(i);

if (pElement->GetObjNum()) {

buf << " " << pElement->GetObjNum() << " 0 R";