Use std::vector as internal storage for CPDF_Array

core/fpdfapi/fpdf_parser/cpdf_document.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h"
 
 #include <set>
 
@@ skipping 14 matching lines @@
                std::set<CPDF_Dictionary*>* visited_pages) {
   int count = pPages->GetIntegerBy("Count");
   if (count > 0 && count < FPDF_PAGE_MAX_NUM) {
     return count;
   }
   CPDF_Array* pKidList = pPages->GetArrayBy("Kids");
   if (!pKidList) {
     return 0;
   }
   count = 0;
-  for (uint32_t i = 0; i < pKidList->GetCount(); i++) {
+  for (size_t i = 0; i < pKidList->GetCount(); i++) {
     CPDF_Dictionary* pKid = pKidList->GetDictAt(i);
     if (!pKid || pdfium::ContainsKey(*visited_pages, pKid)) {
       continue;
     }
     if (pKid->KeyExist("Kids")) {
       // Use |visited_pages| to help detect circular references of pages.
       pdfium::ScopedSetInsertion<CPDF_Dictionary*> local_add(visited_pages,
                                                              pKid);
       count += CountPages(pKid, visited_pages);
     } else {
@@ skipping 102 matching lines @@
   CPDF_Array* pKidList = pPages->GetArrayBy("Kids");
   if (!pKidList) {
     if (nPagesToGo == 0) {
       return pPages;
     }
     return NULL;
   }
   if (level >= FX_MAX_PAGE_LEVEL) {
     return NULL;
   }
-  int nKids = pKidList->GetCount();
-  for (int i = 0; i < nKids; i++) {
+  for (size_t i = 0; i < pKidList->GetCount(); i++) {
     CPDF_Dictionary* pKid = pKidList->GetDictAt(i);
     if (!pKid) {
       nPagesToGo--;
       continue;
     }
     if (pKid == pPages) {
       continue;
     }
     if (!pKid->KeyExist("Kids")) {
       if (nPagesToGo == 0) {
@@ skipping 51 matching lines @@
                                   int& index,
                                   int level) {
   if (pNode->KeyExist("Kids")) {
     CPDF_Array* pKidList = pNode->GetArrayBy("Kids");
     if (!pKidList) {
       return -1;
     }
     if (level >= FX_MAX_PAGE_LEVEL) {
       return -1;
     }
-    uint32_t count = pNode->GetIntegerBy("Count");
+    size_t count = pNode->GetIntegerBy("Count");
     if (count <= skip_count) {
       skip_count -= count;
       index += count;
       return -1;
     }
     if (count && count == pKidList->GetCount()) {
-      for (uint32_t i = 0; i < count; i++) {
+      for (size_t i = 0; i < count; i++) {
         if (CPDF_Reference* pKid = ToReference(pKidList->GetObjectAt(i))) {
           if (pKid->GetRefObjNum() == objnum) {
             m_PageList.SetAt(index + i, objnum);
-            return index + i;
+            return static_cast<int>(index + i);
           }
         }
       }
     }
-    for (uint32_t i = 0; i < pKidList->GetCount(); i++) {
+    for (size_t i = 0; i < pKidList->GetCount(); i++) {
       CPDF_Dictionary* pKid = pKidList->GetDictAt(i);
       if (!pKid) {
         continue;
       }
       if (pKid == pNode) {
         continue;
       }
       int found_index =
           _FindPageIndex(pKid, skip_count, objnum, index, level + 1);
       if (found_index >= 0) {
@@ skipping 89 matching lines @@
 }
 
 void CPDF_Document::ClearRenderFont() {
   if (!m_pDocRender)
     return;
 
   CFX_FontCache* pCache = m_pDocRender->GetFontCache();
   if (pCache)
     pCache->FreeCache(FALSE);
 }