WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc

WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc

Blink now supports DCHECK()s and relatives,
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change
RELEASE_ASSERT --> CHECK
is not exercised due to http://crbug.com/599867
but a TODO is left for that.

See bug for + context.

BUG=596760
TBR=peter@chromium.org

Committed: https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f
Cr-Commit-Position: refs/heads/master@{#385926}

[mcasas, 2016-04-06 17:51:35]

Description was changed from

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED

Blink now supports DCHECK()s and NOTREACHED(), used them instead of
ASSERT() and ASSERT_NOT_REACHED(), respectively. See bug for context.

BUG=596760
==========

to

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives, 
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
RELEASE_ASSERT --> CHECK
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

See bug for + context.

BUG=596760
==========

[mcasas, 2016-04-06 18:25:14]

mcasas@chromium.org changed reviewers:
+ peter@chromium.org

[mcasas, 2016-04-06 18:25:15]

peter@ cleanup CL PTAL

[haraken, 2016-04-06 23:43:59]

The RELEASE_ASSERT --> CHECK replacement caused performance regressions
(https://bugs.chromium.org/p/chromium/issues/detail?id=599867), so I might want
to make further changes until we resolve the regression.

[haraken, 2016-04-06 23:44:21]

On 2016/04/06 23:43:59, haraken wrote:
> The RELEASE_ASSERT --> CHECK replacement caused performance regressions
> (https://bugs.chromium.org/p/chromium/issues/detail?id=599867), so I might
want
> to make further changes until we resolve the regression.

s/I might want to make/I might want to avoid making/

[mcasas, 2016-04-07 00:03:45]

On 2016/04/06 23:44:21, haraken wrote:
> On 2016/04/06 23:43:59, haraken wrote:
> > The RELEASE_ASSERT --> CHECK replacement caused performance regressions
> > (https://bugs.chromium.org/p/chromium/issues/detail?id=599867), so I might
> want
> > to make further changes until we resolve the regression.
> 
> s/I might want to make/I might want to avoid making/

NP, I'll hold this CL.

[mcasas, 2016-04-07 21:40:35]

Description was changed from

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives, 
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
RELEASE_ASSERT --> CHECK
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

See bug for + context.

BUG=596760
==========

to

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives, 
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change 
RELEASE_ASSERT --> CHECK
is not exercised due to bug XX
but a TODO is left for that.

See bug for + context.

BUG=596760
==========

[mcasas, 2016-04-07 21:41:00]

Description was changed from

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives, 
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change 
RELEASE_ASSERT --> CHECK
is not exercised due to bug XX
but a TODO is left for that.

See bug for + context.

BUG=596760
==========

to

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives, 
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change 
RELEASE_ASSERT --> CHECK
is not exercised due to http://crbug.com/599867
but a TODO is left for that.

See bug for + context.

BUG=596760
==========

[mcasas, 2016-04-07 21:41:35]

mcasas@chromium.org changed reviewers:
+ haraken@chromium.org

[mcasas, 2016-04-07 21:41:36]

haraken@ can you RS this?

I reverted the RELEASE_ASSERT change (left a TODO)

[haraken, 2016-04-07 23:28:14]

LGTM

[mcasas, 2016-04-07 23:39:51]

Description was changed from

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives, 
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change 
RELEASE_ASSERT --> CHECK
is not exercised due to http://crbug.com/599867
but a TODO is left for that.

See bug for + context.

BUG=596760
==========

to

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives, 
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change 
RELEASE_ASSERT --> CHECK
is not exercised due to http://crbug.com/599867
but a TODO is left for that.

See bug for + context.

BUG=596760
TBR=peter@chomium.org
==========

[mcasas, 2016-04-07 23:39:52]

mcasas@chromium.org changed reviewers:
- peter@chromium.org

[mcasas, 2016-04-07 23:40:02]

Description was changed from

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives, 
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change 
RELEASE_ASSERT --> CHECK
is not exercised due to http://crbug.com/599867
but a TODO is left for that.

See bug for + context.

BUG=596760
TBR=peter@chomium.org
==========

to

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives, 
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change 
RELEASE_ASSERT --> CHECK
is not exercised due to http://crbug.com/599867
but a TODO is left for that.

See bug for + context.

BUG=596760
TBR=peter@chromium.org
==========

[mcasas, 2016-04-07 23:40:34]

On 2016/04/07 23:28:14, haraken wrote:
> LGTM

(Sending peter@ to TBR= since I don't think 
this CL is worth stalling, is just a rote conversion).

[mcasas, 2016-04-07 23:40:46]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-04-07 23:41:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1862163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1862163002/40001

[commit-bot: I haz the power, 2016-04-07 23:47:12]

Description was changed from

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives, 
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change 
RELEASE_ASSERT --> CHECK
is not exercised due to http://crbug.com/599867
but a TODO is left for that.

See bug for + context.

BUG=596760
TBR=peter@chromium.org
==========

to

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives, 
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change 
RELEASE_ASSERT --> CHECK
is not exercised due to http://crbug.com/599867
but a TODO is left for that.

See bug for + context.

BUG=596760
TBR=peter@chromium.org
==========

[commit-bot: I haz the power, 2016-04-07 23:47:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-07 23:48:21]

Description was changed from

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives, 
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change 
RELEASE_ASSERT --> CHECK
is not exercised due to http://crbug.com/599867
but a TODO is left for that.

See bug for + context.

BUG=596760
TBR=peter@chromium.org
==========

to

==========
WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED
etc

Blink now supports DCHECK()s and relatives,
this CL replaces:

ASSERT --> DCHECK
ASSERT_NOT_REACHED --> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION --> SECURITY_DCHECK

This change
RELEASE_ASSERT --> CHECK
is not exercised due to http://crbug.com/599867
but a TODO is left for that.

See bug for + context.

BUG=596760
TBR=peter@chromium.org

Committed: https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f
Cr-Commit-Position: refs/heads/master@{#385926}
==========

[commit-bot: I haz the power, 2016-04-07 23:48:22]

Patchset 3 (id:??) landed as
https://crrev.com/629fcdb3ac86ab9ebd8634ee2c6e9a5b7ade479f
Cr-Commit-Position: refs/heads/master@{#385926}