Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaErrorState.cpp

Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverted CHECK --> RELEASE_ASSERT and added TODO Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/MediaErrorState.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/MediaErrorState.cpp b/third_party/WebKit/Source/modules/mediastream/MediaErrorState.cpp
index 1480b0e6480bc3c4a553f6a11cd760ac5791b4c4..8763bad8557988543e67ef379e93e226d61e2877 100644
--- a/third_party/WebKit/Source/modules/mediastream/MediaErrorState.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/MediaErrorState.cpp
@@ -80,7 +80,7 @@ void MediaErrorState::raiseException(ExceptionState& target)
{
switch (m_errorType) {
case NoError:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
break;
case TypeError:
target.throwTypeError(m_message);
@@ -97,7 +97,7 @@ void MediaErrorState::raiseException(ExceptionState& target)
target.throwDOMException(NotSupportedError, "Unsatisfiable constraint " + m_constraint);
break;
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
}
@@ -105,7 +105,7 @@ String MediaErrorState::getErrorMessage()
{
switch (m_errorType) {
case NoError:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
break;
case TypeError:
case DOMException:
@@ -118,7 +118,7 @@ String MediaErrorState::getErrorMessage()
// TODO(hta): Remove this code. https://crbug.com/576581
return "Unsatisfiable constraint " + m_constraint;
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
return String();
@@ -126,7 +126,7 @@ String MediaErrorState::getErrorMessage()
NavigatorUserMediaError* MediaErrorState::createError()
{
- ASSERT(m_errorType == ConstraintError);
+ DCHECK(m_errorType == ConstraintError);
return NavigatorUserMediaError::create(NavigatorUserMediaError::NameConstraintNotSatisfied, m_message, m_constraint);
}

Powered by Google App Engine
This is Rietveld 408576698