Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverted CHECK --> RELEASE_ASSERT and added TODO Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp b/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp
index fdf866c985f7ba3bedc749ad17f05e4fd931ce5e..0aae7f364981ecdf5047a95bc8b2e79e56b49919 100644
--- a/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp
@@ -58,7 +58,7 @@ static WebMediaConstraints parseOptions(ExecutionContext* context, const Boolean
} else if (options.isMediaTrackConstraintSet()) {
constraints = MediaConstraintsImpl::create(context, options.getAsMediaTrackConstraintSet(), errorState);
} else {
- ASSERT(options.isBoolean());
+ DCHECK(options.isBoolean());
if (options.getAsBoolean()) {
constraints = MediaConstraintsImpl::create();
}
@@ -187,7 +187,7 @@ void UserMediaRequest::failPermissionDenied(const String& message)
void UserMediaRequest::failConstraint(const String& constraintName, const String& message)
{
- ASSERT(!constraintName.isEmpty());
+ DCHECK(!constraintName.isEmpty());
if (!getExecutionContext())
return;
m_errorCallback->handleEvent(NavigatorUserMediaError::create(NavigatorUserMediaError::NameConstraintNotSatisfied, message, constraintName));
@@ -195,7 +195,7 @@ void UserMediaRequest::failConstraint(const String& constraintName, const String
void UserMediaRequest::failUASpecific(const String& name, const String& message, const String& constraintName)
{
- ASSERT(!name.isEmpty());
+ DCHECK(!name.isEmpty());
if (!getExecutionContext())
return;
m_errorCallback->handleEvent(NavigatorUserMediaError::create(name, message, constraintName));
« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698