third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.cpp - Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.cpp

Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reverted CHECK --> RELEASE_ASSERT and added TODO Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.cpp ('k') | third_party/WebKit/Source/modules/mediastream/NavigatorUserMediaError.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.cpp b/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.cpp

index b2291b3b44732d34463080427990b149ac037adf..20b5464fb84e918a291da6534695027b78c43512 100644

--- a/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.cpp

@@ -54,7 +54,7 @@ void NavigatorMediaStream::webkitGetUserMedia(Navigator& navigator, const MediaS

MediaErrorState errorState;

UserMediaRequest* request = UserMediaRequest::create(navigator.frame()->document(), userMedia, options, successCallback, errorCallback, errorState);

if (!request) {

- ASSERT(errorState.hadException());

+ DCHECK(errorState.hadException());

if (errorState.canGenerateException()) {

errorState.raiseException(exceptionState);

} else {