third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp - Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp

Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reverted CHECK --> RELEASE_ASSERT and added TODO Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCDTMFToneChangeEvent.cpp ('k') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp b/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp

index 009342e39cc020737f0a2eccda016da7028c43f2..20bddec6b7f8d4ad9e8a834fd29ea3d29bb952bf 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp

@@ -53,7 +53,7 @@ static void throwNoBlobSupportException(ExceptionState& exceptionState)

RTCDataChannel* RTCDataChannel::create(ExecutionContext* context, PassOwnPtr<WebRTCDataChannelHandler> handler)

{

- ASSERT(handler);

+ DCHECK(handler);

return new RTCDataChannel(context, handler);

}

@@ -142,7 +142,7 @@ String RTCDataChannel::readyState() const

return "closed";

}

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return String();

}

@@ -169,7 +169,7 @@ String RTCDataChannel::binaryType() const

case BinaryTypeArrayBuffer:

return "arraybuffer";

}

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return String();

}

@@ -276,7 +276,7 @@ void RTCDataChannel::didReceiveRawData(const char* data, size_t dataLength)

scheduleDispatchEvent(MessageEvent::create(buffer.release()));

return;

}

- ASSERT_NOT_REACHED();

+ NOTREACHED();

}

void RTCDataChannel::didDetectError()