Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.cpp

Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverted CHECK --> RELEASE_ASSERT and added TODO Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 request->suspendIfNeeded(); 44 request->suspendIfNeeded();
45 return request; 45 return request;
46 } 46 }
47 47
48 RTCVoidRequestImpl::RTCVoidRequestImpl(ExecutionContext* context, RTCPeerConnect ion* requester, VoidCallback* successCallback, RTCPeerConnectionErrorCallback* e rrorCallback) 48 RTCVoidRequestImpl::RTCVoidRequestImpl(ExecutionContext* context, RTCPeerConnect ion* requester, VoidCallback* successCallback, RTCPeerConnectionErrorCallback* e rrorCallback)
49 : ActiveDOMObject(context) 49 : ActiveDOMObject(context)
50 , m_successCallback(successCallback) 50 , m_successCallback(successCallback)
51 , m_errorCallback(errorCallback) 51 , m_errorCallback(errorCallback)
52 , m_requester(requester) 52 , m_requester(requester)
53 { 53 {
54 ASSERT(m_requester); 54 DCHECK(m_requester);
55 } 55 }
56 56
57 RTCVoidRequestImpl::~RTCVoidRequestImpl() 57 RTCVoidRequestImpl::~RTCVoidRequestImpl()
58 { 58 {
59 } 59 }
60 60
61 void RTCVoidRequestImpl::requestSucceeded() 61 void RTCVoidRequestImpl::requestSucceeded()
62 { 62 {
63 bool shouldFireCallback = m_requester && m_requester->shouldFireDefaultCallb acks(); 63 bool shouldFireCallback = m_requester && m_requester->shouldFireDefaultCallb acks();
64 if (shouldFireCallback && m_successCallback) 64 if (shouldFireCallback && m_successCallback)
(...skipping 28 matching lines...) Expand all
93 DEFINE_TRACE(RTCVoidRequestImpl) 93 DEFINE_TRACE(RTCVoidRequestImpl)
94 { 94 {
95 visitor->trace(m_successCallback); 95 visitor->trace(m_successCallback);
96 visitor->trace(m_errorCallback); 96 visitor->trace(m_errorCallback);
97 visitor->trace(m_requester); 97 visitor->trace(m_requester);
98 RTCVoidRequest::trace(visitor); 98 RTCVoidRequest::trace(visitor);
99 ActiveDOMObject::trace(visitor); 99 ActiveDOMObject::trace(visitor);
100 } 100 }
101 101
102 } // namespace blink 102 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698