Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.cpp

Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverted CHECK --> RELEASE_ASSERT and added TODO Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 25 matching lines...) Expand all
36 request->suspendIfNeeded(); 36 request->suspendIfNeeded();
37 return request; 37 return request;
38 } 38 }
39 39
40 RTCStatsRequestImpl::RTCStatsRequestImpl(ExecutionContext* context, RTCPeerConne ction* requester, RTCStatsCallback* callback, MediaStreamTrack* selector) 40 RTCStatsRequestImpl::RTCStatsRequestImpl(ExecutionContext* context, RTCPeerConne ction* requester, RTCStatsCallback* callback, MediaStreamTrack* selector)
41 : ActiveDOMObject(context) 41 : ActiveDOMObject(context)
42 , m_successCallback(callback) 42 , m_successCallback(callback)
43 , m_component(selector ? selector->component() : 0) 43 , m_component(selector ? selector->component() : 0)
44 , m_requester(requester) 44 , m_requester(requester)
45 { 45 {
46 ASSERT(m_requester); 46 DCHECK(m_requester);
47 } 47 }
48 48
49 RTCStatsRequestImpl::~RTCStatsRequestImpl() 49 RTCStatsRequestImpl::~RTCStatsRequestImpl()
50 { 50 {
51 } 51 }
52 52
53 RTCStatsResponseBase* RTCStatsRequestImpl::createResponse() 53 RTCStatsResponseBase* RTCStatsRequestImpl::createResponse()
54 { 54 {
55 return RTCStatsResponse::create(); 55 return RTCStatsResponse::create();
56 } 56 }
(...skipping 30 matching lines...) Expand all
87 DEFINE_TRACE(RTCStatsRequestImpl) 87 DEFINE_TRACE(RTCStatsRequestImpl)
88 { 88 {
89 visitor->trace(m_successCallback); 89 visitor->trace(m_successCallback);
90 visitor->trace(m_component); 90 visitor->trace(m_component);
91 visitor->trace(m_requester); 91 visitor->trace(m_requester);
92 RTCStatsRequest::trace(visitor); 92 RTCStatsRequest::trace(visitor);
93 ActiveDOMObject::trace(visitor); 93 ActiveDOMObject::trace(visitor);
94 } 94 }
95 95
96 } // namespace blink 96 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698