third_party/WebKit/Source/modules/mediastream/MediaDeviceInfo.cpp - Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaDeviceInfo.cpp

Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reverted CHECK --> RELEASE_ASSERT and added TODO Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/mediastream/MediaDeviceInfo.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/MediaDeviceInfo.cpp b/third_party/WebKit/Source/modules/mediastream/MediaDeviceInfo.cpp

index 11e9110c6c2a17249f727987ae776c42018f05f5..547f804f543d7b15311958077d61e1a335d22b85 100644

--- a/third_party/WebKit/Source/modules/mediastream/MediaDeviceInfo.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/MediaDeviceInfo.cpp

@@ -34,7 +34,7 @@ namespace blink {

MediaDeviceInfo* MediaDeviceInfo::create(const WebMediaDeviceInfo& webMediaDeviceInfo)

{

- ASSERT(!webMediaDeviceInfo.isNull());

+ DCHECK(!webMediaDeviceInfo.isNull());

return new MediaDeviceInfo(webMediaDeviceInfo);

}

@@ -59,7 +59,7 @@ String MediaDeviceInfo::kind() const

return "videoinput";

}

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return String();

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp » ('j') | no next file with comments »