Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestPromiseImpl.cpp

Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverted CHECK --> RELEASE_ASSERT and added TODO Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/mediastream/RTCSessionDescriptionRequestPromiseImpl.h" 5 #include "modules/mediastream/RTCSessionDescriptionRequestPromiseImpl.h"
6 6
7 #include "bindings/core/v8/ScriptPromiseResolver.h" 7 #include "bindings/core/v8/ScriptPromiseResolver.h"
8 #include "core/dom/DOMException.h" 8 #include "core/dom/DOMException.h"
9 #include "core/dom/ExceptionCode.h" 9 #include "core/dom/ExceptionCode.h"
10 #include "modules/mediastream/RTCPeerConnection.h" 10 #include "modules/mediastream/RTCPeerConnection.h"
11 #include "modules/mediastream/RTCSessionDescription.h" 11 #include "modules/mediastream/RTCSessionDescription.h"
12 #include "public/platform/WebRTCSessionDescription.h" 12 #include "public/platform/WebRTCSessionDescription.h"
13 13
14 namespace blink { 14 namespace blink {
15 15
16 RTCSessionDescriptionRequestPromiseImpl* RTCSessionDescriptionRequestPromiseImpl ::create(RTCPeerConnection* requester, ScriptPromiseResolver* resolver) 16 RTCSessionDescriptionRequestPromiseImpl* RTCSessionDescriptionRequestPromiseImpl ::create(RTCPeerConnection* requester, ScriptPromiseResolver* resolver)
17 { 17 {
18 return new RTCSessionDescriptionRequestPromiseImpl(requester, resolver); 18 return new RTCSessionDescriptionRequestPromiseImpl(requester, resolver);
19 } 19 }
20 20
21 RTCSessionDescriptionRequestPromiseImpl::RTCSessionDescriptionRequestPromiseImpl (RTCPeerConnection* requester, ScriptPromiseResolver* resolver) 21 RTCSessionDescriptionRequestPromiseImpl::RTCSessionDescriptionRequestPromiseImpl (RTCPeerConnection* requester, ScriptPromiseResolver* resolver)
22 : m_requester(requester) 22 : m_requester(requester)
23 , m_resolver(resolver) 23 , m_resolver(resolver)
24 { 24 {
25 ASSERT(m_requester); 25 DCHECK(m_requester);
26 ASSERT(m_resolver); 26 DCHECK(m_resolver);
27 } 27 }
28 28
29 RTCSessionDescriptionRequestPromiseImpl::~RTCSessionDescriptionRequestPromiseImp l() 29 RTCSessionDescriptionRequestPromiseImpl::~RTCSessionDescriptionRequestPromiseImp l()
30 { 30 {
31 ASSERT(!m_requester); 31 DCHECK(!m_requester);
32 } 32 }
33 33
34 void RTCSessionDescriptionRequestPromiseImpl::requestSucceeded(const WebRTCSessi onDescription& webSessionDescription) 34 void RTCSessionDescriptionRequestPromiseImpl::requestSucceeded(const WebRTCSessi onDescription& webSessionDescription)
35 { 35 {
36 if (m_requester && m_requester->shouldFireDefaultCallbacks()) { 36 if (m_requester && m_requester->shouldFireDefaultCallbacks()) {
37 m_resolver->resolve(RTCSessionDescription::create(webSessionDescription) ); 37 m_resolver->resolve(RTCSessionDescription::create(webSessionDescription) );
38 } else { 38 } else {
39 // This is needed to have the resolver release its internal resources 39 // This is needed to have the resolver release its internal resources
40 // while leaving the associated promise pending as specified. 40 // while leaving the associated promise pending as specified.
41 m_resolver->detach(); 41 m_resolver->detach();
(...skipping 22 matching lines...) Expand all
64 } 64 }
65 65
66 DEFINE_TRACE(RTCSessionDescriptionRequestPromiseImpl) 66 DEFINE_TRACE(RTCSessionDescriptionRequestPromiseImpl)
67 { 67 {
68 visitor->trace(m_resolver); 68 visitor->trace(m_resolver);
69 visitor->trace(m_requester); 69 visitor->trace(m_requester);
70 RTCSessionDescriptionRequest::trace(visitor); 70 RTCSessionDescriptionRequest::trace(visitor);
71 } 71 }
72 72
73 } // namespace blink 73 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698