WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc

third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

 /*
  * Copyright (C) 2011 Ericsson AB. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 40 matching lines @@
 static WebMediaConstraints parseOptions(ExecutionContext* context, const BooleanOrMediaTrackConstraintSet& options, MediaErrorState& errorState)
 {
     WebMediaConstraints constraints;
 
     Dictionary constraintsDictionary;
     if (options.isNull()) {
         // Do nothing.
     } else if (options.isMediaTrackConstraintSet()) {
         constraints = MediaConstraintsImpl::create(context, options.getAsMediaTrackConstraintSet(), errorState);
     } else {
-        ASSERT(options.isBoolean());
+        DCHECK(options.isBoolean());
         if (options.getAsBoolean()) {
             constraints = MediaConstraintsImpl::create();
         }
     }
 
     return constraints;
 }
 
 UserMediaRequest* UserMediaRequest::create(ExecutionContext* context, UserMediaController* controller, const MediaStreamConstraints& options, NavigatorUserMediaSuccessCallback* successCallback, NavigatorUserMediaErrorCallback* errorCallback, MediaErrorState& errorState)
 {
@@ skipping 108 matching lines @@
 
 void UserMediaRequest::failPermissionDenied(const String& message)
 {
     if (!getExecutionContext())
         return;
     m_errorCallback->handleEvent(NavigatorUserMediaError::create(NavigatorUserMediaError::NamePermissionDenied, message, String()));
 }
 
 void UserMediaRequest::failConstraint(const String& constraintName, const String& message)
 {
-    ASSERT(!constraintName.isEmpty());
+    DCHECK(!constraintName.isEmpty());
     if (!getExecutionContext())
         return;
     m_errorCallback->handleEvent(NavigatorUserMediaError::create(NavigatorUserMediaError::NameConstraintNotSatisfied, message, constraintName));
 }
 
 void UserMediaRequest::failUASpecific(const String& name, const String& message, const String& constraintName)
 {
-    ASSERT(!name.isEmpty());
+    DCHECK(!name.isEmpty());
     if (!getExecutionContext())
         return;
     m_errorCallback->handleEvent(NavigatorUserMediaError::create(name, message, constraintName));
 }
 
 void UserMediaRequest::contextDestroyed()
 {
     if (m_controller) {
         m_controller->cancelUserMediaRequest(this);
         m_controller = nullptr;
     }
 
     ContextLifecycleObserver::contextDestroyed();
 }
 
 DEFINE_TRACE(UserMediaRequest)
 {
     visitor->trace(m_controller);
     visitor->trace(m_successCallback);
     visitor->trace(m_errorCallback);
     ContextLifecycleObserver::trace(visitor);
 }
 
 } // namespace blink