third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp - Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp

Issue 1862163002: WebKit MediaStream cleanup: ASSERT-->DCHECK and ASSERT_NOT_REACHED-->NOTREACHED etc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reverted CHECK --> RELEASE_ASSERT and added TODO Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp ('k') | third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestPromiseImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 request->suspendIfNeeded();	47 request->suspendIfNeeded();

48 return request;	48 return request;

49 }	49 }

50	50

51 RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl(ExecutionCont ext* context, RTCPeerConnection* requester, RTCSessionDescriptionCallback* succe ssCallback, RTCPeerConnectionErrorCallback* errorCallback)	51 RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl(ExecutionCont ext* context, RTCPeerConnection* requester, RTCSessionDescriptionCallback* succe ssCallback, RTCPeerConnectionErrorCallback* errorCallback)

52 : ActiveDOMObject(context)	52 : ActiveDOMObject(context)

53 , m_successCallback(successCallback)	53 , m_successCallback(successCallback)

54 , m_errorCallback(errorCallback)	54 , m_errorCallback(errorCallback)

55 , m_requester(requester)	55 , m_requester(requester)

56 {	56 {

57 ASSERT(m_requester);	57 DCHECK(m_requester);

58 }	58 }

59	59

60 RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl()	60 RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl()

61 {	61 {

62 }	62 }

63	63

64 void RTCSessionDescriptionRequestImpl::requestSucceeded(const WebRTCSessionDescr iption& webSessionDescription)	64 void RTCSessionDescriptionRequestImpl::requestSucceeded(const WebRTCSessionDescr iption& webSessionDescription)

65 {	65 {

66 bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallba cks() : false;	66 bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallba cks() : false;

67 if (shouldFireCallback && m_successCallback)	67 if (shouldFireCallback && m_successCallback)

(...skipping 25 matching lines...) Expand all Loading...
93 DEFINE_TRACE(RTCSessionDescriptionRequestImpl)	93 DEFINE_TRACE(RTCSessionDescriptionRequestImpl)

94 {	94 {

95 visitor->trace(m_successCallback);	95 visitor->trace(m_successCallback);

96 visitor->trace(m_errorCallback);	96 visitor->trace(m_errorCallback);

97 visitor->trace(m_requester);	97 visitor->trace(m_requester);

98 RTCSessionDescriptionRequest::trace(visitor);	98 RTCSessionDescriptionRequest::trace(visitor);

99 ActiveDOMObject::trace(visitor);	99 ActiveDOMObject::trace(visitor);

100 }	100 }

101	101

102 } // namespace blink	102 } // namespace blink

OLD	NEW