Remove sandbox on Windows.

Remove sandbox on Windows.

This has significant binary size and performance improvements, as well
as fixing a number of long standing bugs.

Experiments show that this reduces launch time and binary size by 10%.

Note: I had to remove chrome_elf too, since there were some dependencies there +robertshield.

I haven't done the GN build yet, that will be in a follow-up CL.

BUG=598392, 594829, 593482, 592320, 592212, 590782, 589177, 588190, 586401, 583038, 583037, 580916, 580800, 572131, 571523, 568836, 559803, 558924, 551665, 550361, 549319, 549308, 523278, 515669, 505813, 504880, 501975, 499523, 498949, 496922, 493414, 487400, 483691, 479903, 476708, 472324, 468713, 464430, 462760, 459166, 456193, 455496, 452613, 446964, 431940, 420296, 419104, 419084, 415503, 413889, 407757, 390785, 356150, 355567, 327360, 322710, 74242
TEST=Launch Chrome. Notice it's faster and smaller.

[Will Harris, 2016-04-01 22:07:05]

Description was changed from

==========
Remove sandbox on Windows.

This has significant binary size and performance improvements, as well
as fixing a number of long standing bugs.

I had to remove chrome_elf too, since there were some dependencies there

BUG=598392,594829,593482,592320,592212,590782,589177,588190,586401,583038,583037,580916,580800,572131,571523,568836,559803,558924,551665,550361,549319,549308,523278,515669,505813,504880,501975,499523,498949,496922,493414,487400,483691,479903,476708,472324,468713,464430,462760,459166,456193,455496,452613,446964,431940,420296,419104,419084,415503,413889,407757,390785,356150,355567,327360,322710,74242
TEST=Launch Chrome. Notice it's faster and smaller.
==========

to

==========
Remove sandbox on Windows.

This has significant binary size and performance improvements, as well
as fixing a number of long standing bugs.

I had to remove chrome_elf too, since there were some dependencies there

BUG=598392,594829,593482,592320,592212,590782,589177,588190,586401,583038,583037,580916,580800,572131,571523,568836,559803,558924,551665,550361,549319,549308,523278,515669,505813,504880,501975,499523,498949,496922,493414,487400,483691,479903,476708,472324,468713,464430,462760,459166,456193,455496,452613,446964,431940,420296,419104,419084,415503,413889,407757,390785,356150,355567,327360,322710,74242
TEST=Launch Chrome. Notice it's faster and smaller.
==========

[Will Harris, 2016-04-01 22:07:06]

wfh@chromium.org changed reviewers:
+ cpu@chromium.org, darin@chromium.org, jschuh@chromium.org

[Will Harris, 2016-04-01 22:09:33]

Description was changed from

==========
Remove sandbox on Windows.

This has significant binary size and performance improvements, as well
as fixing a number of long standing bugs.

I had to remove chrome_elf too, since there were some dependencies there

BUG=598392,594829,593482,592320,592212,590782,589177,588190,586401,583038,583037,580916,580800,572131,571523,568836,559803,558924,551665,550361,549319,549308,523278,515669,505813,504880,501975,499523,498949,496922,493414,487400,483691,479903,476708,472324,468713,464430,462760,459166,456193,455496,452613,446964,431940,420296,419104,419084,415503,413889,407757,390785,356150,355567,327360,322710,74242
TEST=Launch Chrome. Notice it's faster and smaller.
==========

to

==========
Remove sandbox on Windows.

This has significant binary size and performance improvements, as well
as fixing a number of long standing bugs.

Experiments show that this reduces launch time and binary size by 10%.

Note: I had to remove chrome_elf too, since there were some dependencies there
+robertshield.

BUG=598392,594829,593482,592320,592212,590782,589177,588190,586401,583038,583037,580916,580800,572131,571523,568836,559803,558924,551665,550361,549319,549308,523278,515669,505813,504880,501975,499523,498949,496922,493414,487400,483691,479903,476708,472324,468713,464430,462760,459166,456193,455496,452613,446964,431940,420296,419104,419084,415503,413889,407757,390785,356150,355567,327360,322710,74242
TEST=Launch Chrome. Notice it's faster and smaller.
==========

[Will Harris, 2016-04-01 22:09:34]

wfh@chromium.org changed reviewers:
+ robertshield@chromium.org

[Will Harris, 2016-04-01 22:10:00]

Description was changed from

==========
Remove sandbox on Windows.

This has significant binary size and performance improvements, as well
as fixing a number of long standing bugs.

Experiments show that this reduces launch time and binary size by 10%.

Note: I had to remove chrome_elf too, since there were some dependencies there
+robertshield.

BUG=598392,594829,593482,592320,592212,590782,589177,588190,586401,583038,583037,580916,580800,572131,571523,568836,559803,558924,551665,550361,549319,549308,523278,515669,505813,504880,501975,499523,498949,496922,493414,487400,483691,479903,476708,472324,468713,464430,462760,459166,456193,455496,452613,446964,431940,420296,419104,419084,415503,413889,407757,390785,356150,355567,327360,322710,74242
TEST=Launch Chrome. Notice it's faster and smaller.
==========

to

==========
Remove sandbox on Windows.

This has significant binary size and performance improvements, as well
as fixing a number of long standing bugs.

Experiments show that this reduces launch time and binary size by 10%.

Note: I had to remove chrome_elf too, since there were some dependencies there
+robertshield.

I haven't done the GN build yet, that will be in a follow-up CL.

BUG=598392,594829,593482,592320,592212,590782,589177,588190,586401,583038,583037,580916,580800,572131,571523,568836,559803,558924,551665,550361,549319,549308,523278,515669,505813,504880,501975,499523,498949,496922,493414,487400,483691,479903,476708,472324,468713,464430,462760,459166,456193,455496,452613,446964,431940,420296,419104,419084,415503,413889,407757,390785,356150,355567,327360,322710,74242
TEST=Launch Chrome. Notice it's faster and smaller.
==========

[Will Harris, 2016-04-01 22:10:24]

PTAL

[robertshield, 2016-04-01 22:37:38]

On 2016/04/01 22:10:24, Will Harris wrote:
> PTAL

Excellent, it's about time we remove the non-critical parts of the browser. This
should also ease application install flow and really help bring new ways of
distributing native code to users on the web. 

I'll send you my related patch to implement window.sudo() that helps skip some
of the remaining irritating barriers to running native code as root from within
a web page.

[brucedawson, 2016-04-02 01:05:33]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2016-04-02 01:05:35]

lgtm

[grt (UTC plus 2), 2016-04-02 11:59:42]

grt@chromium.org changed reviewers:
+ grt@chromium.org

[grt (UTC plus 2), 2016-04-02 11:59:44]

drive-by lgtm.

[Will Harris, 2016-04-02 17:58:38]

This is the second failure I've seen with breakpad, I'm not even sure why it's
compiling it... +scottmg

[scottmg, 2016-04-04 19:47:04]

On 2016/04/02 17:58:38, Will Harris wrote:
> This is the second failure I've seen with breakpad, I'm not even sure why it's
> compiling it... +scottmg

Breakpad is still used by content_shell and chromoting.

[Will Harris, 2016-04-04 19:58:30]

On 2016/04/04 19:47:04, scottmg wrote:
> On 2016/04/02 17:58:38, Will Harris wrote:
> > This is the second failure I've seen with breakpad, I'm not even sure why
it's
> > compiling it... +scottmg
> 
> Breakpad is still used by content_shell and chromoting.

strange, I did not get the compile errors locally, only on try, and I was using
same build targets. oh well. Maybe I'll try and fix these issues next year.

[dglazkov, 2017-02-10 03:36:23]

I am not a fan of the patch. Could we maybe keep the box, but remove all the
sand? For speed?