Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 1851213002: Remove sandbox on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix nacl compile issues Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_content_browser_client.h ('k') | chrome/browser/chrome_elf_init_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 31c8f70af1f6a8d203d2ef405b1615fb23ff6ace..3d9c40c241fc019f6de2a251f6a983844f05504c 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -178,7 +178,6 @@
#include "base/win/windows_version.h"
#include "chrome/browser/chrome_browser_main_win.h"
#include "components/startup_metric_utils/common/pre_read_field_trial_utils_win.h"
-#include "sandbox/win/src/sandbox_policy.h"
#elif defined(OS_MACOSX)
#include "chrome/browser/chrome_browser_main_mac.h"
#elif defined(OS_CHROMEOS)
@@ -2699,27 +2698,6 @@ base::string16 ChromeContentBrowserClient::GetAppContainerSidForSandboxType(
return base::string16();
}
-bool ChromeContentBrowserClient::PreSpawnRenderer(
- sandbox::TargetPolicy* policy) {
- // This code is duplicated in nacl_exe_win_64.cc.
- // Allow the server side of a pipe restricted to the "chrome.nacl."
- // namespace so that it cannot impersonate other system or other chrome
- // service pipes.
- sandbox::ResultCode result = policy->AddRule(
- sandbox::TargetPolicy::SUBSYS_NAMED_PIPES,
- sandbox::TargetPolicy::NAMEDPIPES_ALLOW_ANY,
- L"\\\\.\\pipe\\chrome.nacl.*");
- if (result != sandbox::SBOX_ALL_OK)
- return false;
-
- // Renderers need to send named pipe handles and shared memory
- // segment handles to NaCl loader processes.
- result = policy->AddRule(sandbox::TargetPolicy::SUBSYS_HANDLES,
- sandbox::TargetPolicy::HANDLES_DUP_ANY,
- L"File");
- return result == sandbox::SBOX_ALL_OK;
-}
-
bool ChromeContentBrowserClient::IsWin32kLockdownEnabledForMimeType(
const std::string& mime_type) const {
// First, check if any variation parameters have enabled or disabled this
« no previous file with comments | « chrome/browser/chrome_content_browser_client.h ('k') | chrome/browser/chrome_elf_init_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698