Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7128)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

Issue 1851213002: Remove sandbox on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix nacl compile issues Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
index 829fd6d07cc321542cb0c8949703dd0cd8f21ca5..c97c8e141124f20acf5f58748b30007b16b68e48 100644
--- a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
@@ -25,7 +25,6 @@
#include "chrome/browser/safe_browsing/path_sanitizer.h"
#include "chrome/common/safe_browsing/binary_feature_extractor.h"
#include "chrome/common/safe_browsing/csd.pb.h"
-#include "chrome_elf/chrome_elf_constants.h"
#include "components/variations/variations_associated_data.h"
namespace safe_browsing {
@@ -37,7 +36,6 @@ const REGSAM kKeyReadNoNotify = (KEY_READ) & ~(KEY_NOTIFY);
// The modules on which we will run VerifyModule.
const wchar_t* const kModulesToVerify[] = {
L"chrome.dll",
- L"chrome_elf.dll",
L"ntdll.dll",
};
@@ -235,14 +233,7 @@ void RecordLspFeature(ClientIncidentReport_EnvironmentData_Process* process) {
void CollectDllBlacklistData(
ClientIncidentReport_EnvironmentData_Process* process) {
- PathSanitizer path_sanitizer;
- base::win::RegistryValueIterator iter(HKEY_CURRENT_USER,
- blacklist::kRegistryFinchListPath);
- for (; iter.Valid(); ++iter) {
- base::FilePath dll_name(iter.Value());
- path_sanitizer.StripHomeDirectory(&dll_name);
- process->add_blacklisted_dll(dll_name.AsUTF8Unsafe());
- }
+ // TODO(implement this).
}
void CollectModuleVerificationData(
« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698