Refactor content/common/gpu into gpu/ipc/service

content/common/gpu/media/gpu_video_decode_accelerator_factory_impl.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_GPU_MEDIA_GPU_VIDEO_DECODE_ACCELERATOR_FACTORY_IMPL_H_
 #define CONTENT_COMMON_GPU_MEDIA_GPU_VIDEO_DECODE_ACCELERATOR_FACTORY_IMPL_H_
 
 #include "base/callback.h"
 #include "base/threading/thread_checker.h"
+#include "content/common/content_export.h"
 #include "gpu/command_buffer/service/gpu_preferences.h"
 #include "gpu/config/gpu_info.h"
 #include "media/video/video_decode_accelerator.h"
 
 namespace gfx {
 class GLContext;
 }
 
 namespace gl {
 class GLImage;
 }
 
 namespace gpu {
 struct GpuPreferences;
 
 namespace gles2 {
 class GLES2Decoder;
 }
 }
 
 namespace content {
 
 // TODO(posciak): this class should be an implementation of
 // content::GpuVideoDecodeAcceleratorFactory, however that can only be achieved
 // once this is moved out of content/common, see crbug.com/597150 and related.
-class GpuVideoDecodeAcceleratorFactoryImpl {
- public:
+class
+#if defined(CONTENT_IMPLEMENTATION)
+CONTENT_EXPORT
+#endif

[piman, 2016/04/07 22:26:58]

Please just add CONTENT_EXPORT unconditionally (just remove the #if defined)

[Mark Dittmer, 2016/04/08 13:08:43]

Done.

+GpuVideoDecodeAcceleratorFactoryImpl {
+public:
   ~GpuVideoDecodeAcceleratorFactoryImpl();
 
   // Return current GLContext.
   using GetGLContextCallback = base::Callback<gfx::GLContext*(void)>;
 
   // Make the applicable GL context current. To be called by VDAs before
   // executing any GL calls. Return true on success, false otherwise.
   using MakeGLContextCurrentCallback = base::Callback<bool(void)>;
 
   // Bind |image| to |client_texture_id| given |texture_target|. If
@@ skipping 66 matching lines @@
   const GetGLES2DecoderCallback get_gles2_decoder_cb_;
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(GpuVideoDecodeAcceleratorFactoryImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_GPU_MEDIA_GPU_VIDEO_DECODE_ACCELERATOR_FACTORY_IMPL_H_