Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1738443002: Subzero. Performance tweaks. (Closed)

Created:
4 years, 10 months ago by John
Modified:
4 years, 10 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero. Performance tweaks. Introduces Ice::SmallBitVector. Modifies ConstantRelocatables so that known offsets (i.e., not offsets to the code stream) do no require GlobalContext allocations. Modifies Cfg-local containers to use the CfgLocalAllocator. BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e82b560e649f8a68bcb252b9b002708e74d962d3

Patch Set 1 #

Patch Set 2 : Undoes Makefile changes. #

Total comments: 38

Patch Set 3 : Addresses comments. #

Patch Set 4 : Addresses comments -- all of them #

Unified diffs Side-by-side diffs Delta from patch set Stats (+753 lines, -378 lines) Patch
M Makefile.standalone View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceAssembler.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
A src/IceBitVector.h View 1 2 1 chunk +245 lines, -0 lines 0 comments Download
M src/IceCfg.h View 4 chunks +4 lines, -17 lines 0 comments Download
M src/IceCfg.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M src/IceConverter.cpp View 1 chunk +26 lines, -26 lines 0 comments Download
M src/IceDefs.h View 5 chunks +11 lines, -43 lines 0 comments Download
M src/IceGlobalContext.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 2 6 chunks +14 lines, -18 lines 0 comments Download
A src/IceMemory.h View 1 2 1 chunk +142 lines, -0 lines 0 comments Download
A src/IceMemory.cpp View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M src/IceOperand.h View 8 chunks +34 lines, -25 lines 0 comments Download
M src/IceOperand.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M src/IceRegAlloc.h View 5 chunks +10 lines, -11 lines 0 comments Download
M src/IceRegAlloc.cpp View 18 chunks +22 lines, -22 lines 0 comments Download
M src/IceTLS.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceTargetLowering.h View 4 chunks +11 lines, -10 lines 0 comments Download
M src/IceTargetLowering.cpp View 8 chunks +15 lines, -16 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 9 chunks +16 lines, -22 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 8 chunks +20 lines, -24 lines 0 comments Download
M src/IceTargetLoweringMIPS32.h View 2 chunks +10 lines, -11 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/IceTargetLoweringX8632Traits.h View 3 chunks +18 lines, -19 lines 0 comments Download
M src/IceTargetLoweringX8664.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M src/IceTargetLoweringX8664Traits.h View 3 chunks +19 lines, -20 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 4 chunks +11 lines, -13 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 10 chunks +15 lines, -15 lines 0 comments Download
M src/PNaClTranslator.cpp View 1 2 3 1 chunk +26 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jim Stichnoth
Initial round. https://codereview.chromium.org/1738443002/diff/20001/src/IceBitVector.h File src/IceBitVector.h (right): https://codereview.chromium.org/1738443002/diff/20001/src/IceBitVector.h#newcode1 src/IceBitVector.h:1: remove leading blank line https://codereview.chromium.org/1738443002/diff/20001/src/IceBitVector.h#newcode12 src/IceBitVector.h:12: /// ...
4 years, 10 months ago (2016-02-24 23:11:39 UTC) #4
Jim Stichnoth
More comments https://codereview.chromium.org/1738443002/diff/20001/src/IceAssembler.h File src/IceAssembler.h (right): https://codereview.chromium.org/1738443002/diff/20001/src/IceAssembler.h#newcode341 src/IceAssembler.h:341: ArenaAllocator Allocator; So the assembler arena size ...
4 years, 10 months ago (2016-02-24 23:23:32 UTC) #5
Jim Stichnoth
https://codereview.chromium.org/1738443002/diff/20001/src/PNaClTranslator.cpp File src/PNaClTranslator.cpp (right): https://codereview.chromium.org/1738443002/diff/20001/src/PNaClTranslator.cpp#newcode1384 src/PNaClTranslator.cpp:1384: // reported, without adding extra checks to the translator ...
4 years, 10 months ago (2016-02-24 23:31:25 UTC) #6
John
https://codereview.chromium.org/1738443002/diff/20001/src/IceAssembler.h File src/IceAssembler.h (right): https://codereview.chromium.org/1738443002/diff/20001/src/IceAssembler.h#newcode341 src/IceAssembler.h:341: ArenaAllocator Allocator; On 2016/02/24 23:23:32, stichnot wrote: > So ...
4 years, 10 months ago (2016-02-24 23:46:06 UTC) #7
Jim Stichnoth
lgtm
4 years, 10 months ago (2016-02-24 23:50:47 UTC) #8
John
4 years, 10 months ago (2016-02-24 23:58:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
e82b560e649f8a68bcb252b9b002708e74d962d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698