Subzero. Performance tweaks.

src/IceAssembler.h

 //===- subzero/src/IceAssembler.h - Integrated assembler --------*- C++ -*-===//
 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Modified by the Subzero authors.
 //
 //===----------------------------------------------------------------------===//
 //
 //                        The Subzero Code Generator
@@ skipping 320 matching lines @@
 
   AssemblerKind getKind() const { return Kind; }
 
 protected:
   explicit Assembler(AssemblerKind Kind)
       : Kind(Kind), Allocator(), Buffer(*this) {}
 
 private:
   const AssemblerKind Kind;
 
-  ArenaAllocator<32 * 1024> Allocator;
+  ArenaAllocator Allocator;

[Jim Stichnoth, 2016/02/24 23:23:32]

So the assembler arena size increases now, hope that's not a perf issue.  I
recall this being tweaked a long time ago for perf reasons.

[John, 2016/02/24 23:46:05]

It was very unfortunate that ArenaAllocator was a template -- we had <> spread
all over the place because of that. I defined a new, assembler-local arena type.

   /// FunctionName and IsInternal are transferred from the original Cfg object,
   /// since the Cfg object may be deleted by the time the assembler buffer is
   /// emitted.
   IceString FunctionName = "";
   bool IsInternal = false;
   /// Preliminary indicates whether a preliminary pass is being made for
   /// calculating bundle padding (Preliminary=true), versus the final pass where
   /// all changes to label bindings, label links, and relocation fixups are
   /// fully committed (Preliminary=false).
   bool Preliminary = false;
 
   /// Installs a created fixup, after it has been allocated.
   void installFixup(AssemblerFixup *F) { Buffer.installFixup(F); }
 
 protected:
   // Buffer's constructor uses the Allocator, so it needs to appear after it.
   // TODO(jpp): dependencies on construction order are a nice way of shooting
   // yourself in the foot. Fix this.
   AssemblerBuffer Buffer;
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEASSEMBLER_H_