Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1685353004: Clean up Image::computeIntrinsicDimensions (Closed)

Created:
4 years, 10 months ago by davve
Modified:
4 years, 10 months ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), gavinp+loader_chromium.org, gyuyoung2, Nate Chapin, jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, loading-reviews+fetch_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, vmpstr+blinkwatch_chromium.org, Yoav Weiss, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up computeIntrinsicDimensions No need to carry around Length for intrinsic width or height anymore. A FloatSize does fine when all lengths are fixed. BUG=581357, 585467 Committed: https://crrev.com/23d6a478c76d5e31c8bb47fa31bd53f619b536bd Cr-Commit-Position: refs/heads/master@{#376956}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -64 lines) Patch
M third_party/WebKit/Source/core/fetch/ImageResource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 3 chunks +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp View 1 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleInvalidImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StylePendingImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GeneratedImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
davve
Image::computeIntrinsicDimensions is a function I'm a bit eager to get rid of (not yet sure ...
4 years, 10 months ago (2016-02-12 10:28:16 UTC) #2
fs
LGTM w/ nits/suggestions https://codereview.chromium.org/1685353004/diff/1/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right): https://codereview.chromium.org/1685353004/diff/1/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp#newcode736 third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:736: LayoutSize resolvedSize(intrinsicSize.width(), intrinsicSize.height()); Nit: Use LayoutSize(const ...
4 years, 10 months ago (2016-02-12 11:24:47 UTC) #3
fs
+fmalita, schenney for platform/
4 years, 10 months ago (2016-02-12 11:25:30 UTC) #5
davve
https://codereview.chromium.org/1685353004/diff/1/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right): https://codereview.chromium.org/1685353004/diff/1/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp#newcode736 third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:736: LayoutSize resolvedSize(intrinsicSize.width(), intrinsicSize.height()); On 2016/02/12 11:24:46, fs wrote: > ...
4 years, 10 months ago (2016-02-12 11:58:30 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685353004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685353004/20001
4 years, 10 months ago (2016-02-12 11:58:56 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-12 13:24:05 UTC) #11
davve
ping
4 years, 10 months ago (2016-02-17 14:27:07 UTC) #12
davve
Trying +pdr for platform/
4 years, 10 months ago (2016-02-22 11:24:20 UTC) #13
davve
Actually add him too.
4 years, 10 months ago (2016-02-22 11:24:45 UTC) #15
pdr.
On 2016/02/22 at 11:24:45, davve wrote: > Actually add him too. platform LGTM. I only ...
4 years, 10 months ago (2016-02-22 22:42:20 UTC) #16
davve
On 2016/02/22 22:42:20, pdr wrote: > On 2016/02/22 at 11:24:45, davve wrote: > > Actually ...
4 years, 10 months ago (2016-02-23 08:13:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685353004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685353004/20001
4 years, 10 months ago (2016-02-23 08:17:38 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-23 09:37:55 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 09:39:18 UTC) #24
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/23d6a478c76d5e31c8bb47fa31bd53f619b536bd
Cr-Commit-Position: refs/heads/master@{#376956}

Powered by Google App Engine
This is Rietveld 408576698