third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h - Issue 1685353004: Clean up Image::computeIntrinsicDimensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h

Issue 1685353004: Clean up Image::computeIntrinsicDimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h

diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h b/third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h

index b7e2930f1537888eddf19f6c0d74d878fef812a9..3f8cd37a3845dc0f2c33373789eaa902cf7bafdc 100644

--- a/third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h

+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h

@@ -49,9 +49,9 @@ public:

bool usesContainerSize() const override { return m_image->usesContainerSize(); }

bool hasRelativeSize() const override { return m_image->hasRelativeSize(); }

- void computeIntrinsicDimensions(Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio) override

+ void computeIntrinsicDimensions(FloatSize& intrinsicSize, FloatSize& intrinsicRatio) override

{

- m_image->computeIntrinsicDimensions(intrinsicWidth, intrinsicHeight, intrinsicRatio);

+ m_image->computeIntrinsicDimensions(intrinsicSize, intrinsicRatio);

}

void draw(SkCanvas*, const SkPaint&, const FloatRect&, const FloatRect&, RespectImageOrientationEnum, ImageClampingMode) override;