third_party/WebKit/Source/core/style/StyleGeneratedImage.h - Issue 1685353004: Clean up Image::computeIntrinsicDimensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleGeneratedImage.h

Issue 1685353004: Clean up Image::computeIntrinsicDimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/StyleGeneratedImage.h

diff --git a/third_party/WebKit/Source/core/style/StyleGeneratedImage.h b/third_party/WebKit/Source/core/style/StyleGeneratedImage.h

index 6a810b399cc74c9de5118dba90432bbcdef0c07f..fddded5e25ef52c51b2012ff65192724b9f74659 100644

--- a/third_party/WebKit/Source/core/style/StyleGeneratedImage.h

+++ b/third_party/WebKit/Source/core/style/StyleGeneratedImage.h

@@ -46,7 +46,7 @@ public:

LayoutSize imageSize(const LayoutObject*, float multiplier) const override;

bool imageHasRelativeSize() const override { return !m_fixedSize; }

- void computeIntrinsicDimensions(const LayoutObject*, Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio) override;

+ void computeIntrinsicDimensions(const LayoutObject*, FloatSize& intrinsicSize, FloatSize& intrinsicRatio) override;

bool usesImageContainerSize() const override { return !m_fixedSize; }

void addClient(LayoutObject*) override;

void removeClient(LayoutObject*) override;