third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp - Issue 1685353004: Clean up Image::computeIntrinsicDimensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

Issue 1685353004: Clean up Image::computeIntrinsicDimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/Source/core/style/StyleFetchedImageSet.h ('k') | third_party/WebKit/Source/core/style/StyleGeneratedImage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

diff --git a/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp b/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

index c02f13b3d710961167cd7a00447ef2134391cca5..0eeb5bb14664187b58e582eeb290f1cd9947ccf1 100644

--- a/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

+++ b/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

@@ -105,9 +105,9 @@ bool StyleFetchedImageSet::imageHasRelativeSize() const

return m_bestFitImage->imageHasRelativeSize();

}

-void StyleFetchedImageSet::computeIntrinsicDimensions(const LayoutObject*, Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio)

+void StyleFetchedImageSet::computeIntrinsicDimensions(const LayoutObject*, FloatSize& intrinsicSize, FloatSize& intrinsicRatio)

{

- m_bestFitImage->computeIntrinsicDimensions(intrinsicWidth, intrinsicHeight, intrinsicRatio);

+ m_bestFitImage->computeIntrinsicDimensions(intrinsicSize, intrinsicRatio);

}

bool StyleFetchedImageSet::usesImageContainerSize() const