third_party/WebKit/Source/platform/graphics/Image.cpp - Issue 1685353004: Clean up Image::computeIntrinsicDimensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/Image.cpp

Issue 1685353004: Clean up Image::computeIntrinsicDimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/Image.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/Image.cpp b/third_party/WebKit/Source/platform/graphics/Image.cpp

index 48e20cfed1c8d568a510f6264f95fbe33702dda0..5ab1d6f47e714896ef405937e8ceda2110650766 100644

--- a/third_party/WebKit/Source/platform/graphics/Image.cpp

+++ b/third_party/WebKit/Source/platform/graphics/Image.cpp

@@ -259,11 +259,9 @@ void Image::drawPattern(GraphicsContext& context, const FloatRect& floatSrcRect,

PlatformInstrumentation::didDrawLazyPixelRef(imageID);

}

-void Image::computeIntrinsicDimensions(Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio)

+void Image::computeIntrinsicDimensions(FloatSize& intrinsicSize, FloatSize& intrinsicRatio)

{

- intrinsicRatio = FloatSize(size());

- intrinsicWidth = Length(intrinsicRatio.width(), Fixed);

- intrinsicHeight = Length(intrinsicRatio.height(), Fixed);

+ intrinsicSize = intrinsicRatio = FloatSize(size());

}

PassRefPtr<Image> Image::imageForDefaultFrame()

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/Image.h ('k') | no next file » | no next file with comments »