Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: third_party/WebKit/Source/core/svg/graphics/SVGImage.h

Issue 1685353004: Clean up Image::computeIntrinsicDimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org>
3 * Copyright (C) 2009 Apple Inc. All rights reserved. 3 * Copyright (C) 2009 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 friend class AXLayoutObject; 85 friend class AXLayoutObject;
86 friend class SVGImageChromeClient; 86 friend class SVGImageChromeClient;
87 friend class SVGImageForContainer; 87 friend class SVGImageForContainer;
88 88
89 ~SVGImage() override; 89 ~SVGImage() override;
90 90
91 String filenameExtension() const override; 91 String filenameExtension() const override;
92 92
93 IntSize containerSize() const; 93 IntSize containerSize() const;
94 bool usesContainerSize() const override { return true; } 94 bool usesContainerSize() const override { return true; }
95 void computeIntrinsicDimensions(Length& intrinsicWidth, Length& intrinsicHei ght, FloatSize& intrinsicRatio) override; 95 void computeIntrinsicDimensions(FloatSize& intrinsicSize, FloatSize& intrins icRatio) override;
96 96
97 bool dataChanged(bool allDataReceived) override; 97 bool dataChanged(bool allDataReceived) override;
98 98
99 // FIXME: SVGImages are underreporting decoded sizes and will be unable 99 // FIXME: SVGImages are underreporting decoded sizes and will be unable
100 // to prune because these functions are not implemented yet. 100 // to prune because these functions are not implemented yet.
101 void destroyDecodedData(bool) override { } 101 void destroyDecodedData(bool) override { }
102 102
103 // FIXME: Implement this to be less conservative. 103 // FIXME: Implement this to be less conservative.
104 bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override { return false; } 104 bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override { return false; }
105 105
(...skipping 29 matching lines...) Expand all
135 m_image->setImageObserver(m_observer); 135 m_image->setImageObserver(m_observer);
136 } 136 }
137 private: 137 private:
138 Image* m_image; 138 Image* m_image;
139 RawPtrWillBeMember<ImageObserver> m_observer; 139 RawPtrWillBeMember<ImageObserver> m_observer;
140 }; 140 };
141 141
142 } // namespace blink 142 } // namespace blink
143 143
144 #endif // SVGImage_h 144 #endif // SVGImage_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGSVGElement.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698