third_party/WebKit/Source/core/style/StyleImage.h - Issue 1685353004: Clean up Image::computeIntrinsicDimensions

Side by Side Diff: third_party/WebKit/Source/core/style/StyleImage.h

Issue 1685353004: Clean up Image::computeIntrinsicDimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)

3 * (C) 2000 Antti Koivisto (koivisto@kde.org)	3 * (C) 2000 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Dirk Mueller (mueller@kde.org)	4 * (C) 2000 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.	5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
50 return data() == other.data();	50 return data() == other.data();

51 }	51 }

52	52

53 virtual PassRefPtrWillBeRawPtr<CSSValue> cssValue() const = 0;	53 virtual PassRefPtrWillBeRawPtr<CSSValue> cssValue() const = 0;

54 virtual PassRefPtrWillBeRawPtr<CSSValue> computedCSSValue() const = 0;	54 virtual PassRefPtrWillBeRawPtr<CSSValue> computedCSSValue() const = 0;

55	55

56 virtual bool canRender() const { return true; }	56 virtual bool canRender() const { return true; }

57 virtual bool isLoaded() const { return true; }	57 virtual bool isLoaded() const { return true; }

58 virtual bool errorOccurred() const { return false; }	58 virtual bool errorOccurred() const { return false; }

59 virtual LayoutSize imageSize(const LayoutObject*, float multiplier) const = 0;	59 virtual LayoutSize imageSize(const LayoutObject*, float multiplier) const = 0;

60 virtual void computeIntrinsicDimensions(const LayoutObject*, Length& intrins icWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio) = 0;	60 virtual void computeIntrinsicDimensions(const LayoutObject*, FloatSize& intr insicSize, FloatSize& intrinsicRatio) = 0;

61 virtual bool imageHasRelativeSize() const = 0;	61 virtual bool imageHasRelativeSize() const = 0;

62 virtual bool usesImageContainerSize() const = 0;	62 virtual bool usesImageContainerSize() const = 0;

63 virtual void addClient(LayoutObject*) = 0;	63 virtual void addClient(LayoutObject*) = 0;

64 virtual void removeClient(LayoutObject*) = 0;	64 virtual void removeClient(LayoutObject*) = 0;

65 virtual PassRefPtr<Image> image(const LayoutObject*, const IntSize&, float) const = 0;	65 virtual PassRefPtr<Image> image(const LayoutObject*, const IntSize&, float) const = 0;

66 virtual WrappedImagePtr data() const = 0;	66 virtual WrappedImagePtr data() const = 0;

67 virtual float imageScaleFactor() const { return 1; }	67 virtual float imageScaleFactor() const { return 1; }

68 virtual bool knownToBeOpaque(const LayoutObject*) const = 0;	68 virtual bool knownToBeOpaque(const LayoutObject*) const = 0;

69 virtual ImageResource* cachedImage() const { return 0; }	69 virtual ImageResource* cachedImage() const { return 0; }

70	70

(...skipping 21 matching lines...) Expand all Loading...
92 bool m_isInvalidImage:1;	92 bool m_isInvalidImage:1;

93 };	93 };

94	94

95 #define DEFINE_STYLE_IMAGE_TYPE_CASTS(thisType, function) \	95 #define DEFINE_STYLE_IMAGE_TYPE_CASTS(thisType, function) \

96 DEFINE_TYPE_CASTS(thisType, StyleImage, styleImage, styleImage->function, st yleImage.function); \	96 DEFINE_TYPE_CASTS(thisType, StyleImage, styleImage, styleImage->function, st yleImage.function); \

97 inline thisType* to##thisType(const RefPtrWillBeMember<StyleImage>& styleIma ge) { return to##thisType(styleImage.get()); } \	97 inline thisType* to##thisType(const RefPtrWillBeMember<StyleImage>& styleIma ge) { return to##thisType(styleImage.get()); } \

98 typedef int NeedsSemiColonAfterDefineStyleImageTypeCasts	98 typedef int NeedsSemiColonAfterDefineStyleImageTypeCasts

99	99

100 } // namespace blink	100 } // namespace blink

101 #endif	101 #endif

OLD	NEW