third_party/WebKit/Source/core/style/StyleImage.h - Issue 1685353004: Clean up Image::computeIntrinsicDimensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleImage.h

Issue 1685353004: Clean up Image::computeIntrinsicDimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/StyleImage.h

diff --git a/third_party/WebKit/Source/core/style/StyleImage.h b/third_party/WebKit/Source/core/style/StyleImage.h

index b8dcfe770ac3eb9d2105ffb499e2fa457a0232e6..49a050c50ad72504e7272ff7a0b8809677b88724 100644

--- a/third_party/WebKit/Source/core/style/StyleImage.h

+++ b/third_party/WebKit/Source/core/style/StyleImage.h

@@ -57,7 +57,7 @@ public:

virtual bool isLoaded() const { return true; }

virtual bool errorOccurred() const { return false; }

virtual LayoutSize imageSize(const LayoutObject*, float multiplier) const = 0;

- virtual void computeIntrinsicDimensions(const LayoutObject*, Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio) = 0;

+ virtual void computeIntrinsicDimensions(const LayoutObject*, FloatSize& intrinsicSize, FloatSize& intrinsicRatio) = 0;

virtual bool imageHasRelativeSize() const = 0;

virtual bool usesImageContainerSize() const = 0;

virtual void addClient(LayoutObject*) = 0;