third_party/WebKit/Source/platform/graphics/Image.h - Issue 1685353004: Clean up Image::computeIntrinsicDimensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/Image.h

Issue 1685353004: Clean up Image::computeIntrinsicDimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/Image.h

diff --git a/third_party/WebKit/Source/platform/graphics/Image.h b/third_party/WebKit/Source/platform/graphics/Image.h

index 8ee032c702e3be9aff661e5eae7a7ceb75a163d7..089832c197e5a14e75ae4d74942c02ab48900297 100644

--- a/third_party/WebKit/Source/platform/graphics/Image.h

+++ b/third_party/WebKit/Source/platform/graphics/Image.h

@@ -96,7 +96,7 @@ public:

// Computes (extracts) the intrinsic dimensions and ratio from the Image. The intrinsic ratio

// will be the 'viewport' of the image. (Same as the dimensions for a raster image. For SVG

// images it can be the dimensions defined by the 'viewBox'.)

- virtual void computeIntrinsicDimensions(Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio);

+ virtual void computeIntrinsicDimensions(FloatSize& intrinsicSize, FloatSize& intrinsicRatio);

virtual IntSize size() const = 0;

IntRect rect() const { return IntRect(IntPoint(), size()); }