third_party/WebKit/Source/core/fetch/ImageResource.cpp - Issue 1685353004: Clean up Image::computeIntrinsicDimensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.cpp

Issue 1685353004: Clean up Image::computeIntrinsicDimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/ImageResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.cpp b/third_party/WebKit/Source/core/fetch/ImageResource.cpp

index a252a4e72b0c94a5dae54dee86182b0b529d753e..30e13864b184ef5e48bd4a9c0070ccbe5bc0b853 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/ImageResource.cpp

@@ -239,10 +239,10 @@ LayoutSize ImageResource::imageSize(RespectImageOrientationEnum shouldRespectIma

return size;

}

-void ImageResource::computeIntrinsicDimensions(Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio)

+void ImageResource::computeIntrinsicDimensions(FloatSize& intrinsicSize, FloatSize& intrinsicRatio)

{

if (m_image)

- m_image->computeIntrinsicDimensions(intrinsicWidth, intrinsicHeight, intrinsicRatio);

+ m_image->computeIntrinsicDimensions(intrinsicSize, intrinsicRatio);

}

void ImageResource::notifyObservers(const IntRect* changeRect)