Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1666773002: Clean up GrGLSLFragmentProcessor-derived classes (Closed)

Created:
4 years, 10 months ago by robertphillips
Modified:
4 years, 10 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up GrGLSLFragmentProcessor-derived classes In some other patches it was observed that many of the GrGLSLFragmentProcessor-derived classes needlessly pass a parameter to their constructors. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1666773002 Committed: https://skia.googlesource.com/skia/+/9cdb9920fcad286ecf7875ea19902022b644fbdc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -165 lines) Patch
M src/core/SkColorMatrixFilterRowMajor255.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 4 chunks +4 lines, -9 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 3 chunks +2 lines, -11 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/effects/SkPixelXorXfermode.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrFragmentProcessor.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 5 chunks +10 lines, -14 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 6 chunks +7 lines, -13 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 6 chunks +9 lines, -13 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M src/gpu/effects/GrXfermodeFragmentProcessor.cpp View 4 chunks +2 lines, -6 lines 0 comments Download
M src/gpu/effects/GrYUVEffect.cpp View 4 chunks +3 lines, -5 lines 0 comments Download
M src/utils/debugger/SkOverdrawMode.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 10 months ago (2016-02-03 19:26:06 UTC) #4
egdaniel
lgtm
4 years, 10 months ago (2016-02-03 19:44:49 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666773002/1
4 years, 10 months ago (2016-02-03 19:45:34 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-03 20:21:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666773002/1
4 years, 10 months ago (2016-02-03 20:24:49 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 20:25:43 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9cdb9920fcad286ecf7875ea19902022b644fbdc

Powered by Google App Engine
This is Rietveld 408576698