Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: src/effects/SkTableColorFilter.cpp

Issue 1666773002: Clean up GrGLSLFragmentProcessor-derived classes (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/effects/SkPixelXorXfermode.cpp ('k') | src/effects/gradients/SkGradientShader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/effects/SkTableColorFilter.cpp
diff --git a/src/effects/SkTableColorFilter.cpp b/src/effects/SkTableColorFilter.cpp
index d9c07e254cc60416f7c7287380e75b3cd8f83752..c06e4363bf331a9fe01fcf5ccd7b35ab91cca97b 100644
--- a/src/effects/SkTableColorFilter.cpp
+++ b/src/effects/SkTableColorFilter.cpp
@@ -377,9 +377,7 @@ private:
class GLColorTableEffect : public GrGLSLFragmentProcessor {
public:
- GLColorTableEffect(const GrProcessor&);
-
- virtual void emitCode(EmitArgs&) override;
+ void emitCode(EmitArgs&) override;
static void GenKey(const GrProcessor&, const GrGLSLCaps&, GrProcessorKeyBuilder* b) {}
@@ -391,9 +389,6 @@ private:
typedef GrGLSLFragmentProcessor INHERITED;
};
-GLColorTableEffect::GLColorTableEffect(const GrProcessor&) {
-}
-
void GLColorTableEffect::onSetData(const GrGLSLProgramDataManager& pdm, const GrProcessor& proc) {
// The textures are organized in a strip where the rows are ordered a, r, g, b.
float rgbaYValues[4];
@@ -507,7 +502,7 @@ void ColorTableEffect::onGetGLSLProcessorKey(const GrGLSLCaps& caps,
}
GrGLSLFragmentProcessor* ColorTableEffect::onCreateGLSLInstance() const {
- return new GLColorTableEffect(*this);
+ return new GLColorTableEffect;
}
bool ColorTableEffect::onIsEqual(const GrFragmentProcessor& other) const {
« no previous file with comments | « src/effects/SkPixelXorXfermode.cpp ('k') | src/effects/gradients/SkGradientShader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698