Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1556783002: Convert Pass()→std::move() for CrOS extension code. (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
aboxhall+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dkrahn+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, je_julie, kinuko+fileapi, nektar+watch_chromium.org, nhiroki, nona+watch_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, rginda+watch_chromium.org, shuchen+watch_chromium.org, stevenjb+watch_chromium.org, tzik, yusukes+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() for CrOS extension code. (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=reillyg@chromium.org Committed: https://crrev.com/14a43b5473503fdd785cf51403d0154caa3d9d00 Cr-Commit-Position: refs/heads/master@{#367246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -153 lines) Patch
M chrome/browser/chromeos/extensions/default_app_order.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/dictionary_event_router.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/external_cache.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/external_cache_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_stream_md5_digester.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc View 8 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_event_router.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/launcher_search_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/media_player_event_router.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/users_private/users_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_api.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc View 12 chunks +13 lines, -25 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/file_system/request_file_system_notification.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/test_utils.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc View 9 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/platform_keys/platform_keys_api.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/terminal/terminal_private_api.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_widget_private/app_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/networking_config/networking_config_service.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M extensions/browser/api/networking_config/networking_config_service_chromeos_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M extensions/browser/api/socket/app_firewall_hole_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/socket/socket.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/socket/socket_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/api/vpn_provider/vpn_service.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/api/webcam_private/visca_webcam.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
+avi for general review / sanity check +reillyg for OWNERS review
4 years, 11 months ago (2015-12-31 05:49:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556783002/1
4 years, 11 months ago (2015-12-31 05:49:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-31 06:47:36 UTC) #5
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-31 14:52:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556783002/1
4 years, 11 months ago (2015-12-31 16:03:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 16:08:54 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 16:09:44 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/14a43b5473503fdd785cf51403d0154caa3d9d00
Cr-Commit-Position: refs/heads/master@{#367246}

Powered by Google App Engine
This is Rietveld 408576698