extensions/browser/api/socket/app_firewall_hole_manager.cc - Issue 1556783002: Convert Pass()→std::move() for CrOS extension code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/socket/app_firewall_hole_manager.cc

Issue 1556783002: Convert Pass()→std::move() for CrOS extension code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/networking_config/networking_config_service_chromeos_unittest.cc ('k') | extensions/browser/api/socket/socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/socket/app_firewall_hole_manager.cc

diff --git a/extensions/browser/api/socket/app_firewall_hole_manager.cc b/extensions/browser/api/socket/app_firewall_hole_manager.cc

index 76e6b8b0fff6babe2f22e0014c1087022c825d38..f5973734081a1d41c1f3da9718a6a9f67f7fa49e 100644

--- a/extensions/browser/api/socket/app_firewall_hole_manager.cc

+++ b/extensions/browser/api/socket/app_firewall_hole_manager.cc

@@ -100,7 +100,7 @@ void AppFirewallHole::OnFirewallHoleOpened(

scoped_ptr<FirewallHole> firewall_hole) {

if (app_visible_) {

DCHECK(!firewall_hole_);

- firewall_hole_ = firewall_hole.Pass();

+ firewall_hole_ = std::move(firewall_hole);

}

@@ -127,7 +127,7 @@ scoped_ptr<AppFirewallHole> AppFirewallHoleManager::Open(

if (HasVisibleAppWindows(context_, extension_id)) {

hole->SetVisible(true);

}

- return hole.Pass();

+ return hole;

}

void AppFirewallHoleManager::Close(AppFirewallHole* hole) {