chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc - Issue 1556783002: Convert Pass()→std::move() for CrOS extension code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

Issue 1556783002: Convert Pass()→std::move() for CrOS extension code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc ('k') | chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

diff --git a/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc b/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

index dac69c7dc9740bbb2039ab3d85274bf7bd27f79f..bddbdab7e509e915cdc140077ef1dc4d37a35b1a 100644

--- a/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

+++ b/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

@@ -3,6 +3,7 @@

// found in the LICENSE file.

#include <string>

+#include <utility>

#include "base/files/file_path.h"

#include "base/files/file_util.h"

@@ -34,7 +35,7 @@ class TestDebugDaemonClient : public chromeos::FakeDebugDaemonClient {

base::File file,

scoped_refptr<base::TaskRunner> task_runner,

const GetDebugLogsCallback& callback) override {

- base::File* file_param = new base::File(file.Pass());

+ base::File* file_param = new base::File(std::move(file));

task_runner->PostTaskAndReply(

FROM_HERE,

base::Bind(

@@ -82,7 +83,7 @@ class LogPrivateApiTest : public ExtensionApiTest {

response->set_content(

"<html><head><title>LogPrivateTest</title>"

"</head><body>Hello!</body></html>");

- return response.Pass();

+ return std::move(response);

}

};