Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2516)

Unified Diff: chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

Issue 1556783002: Convert Pass()→std::move() for CrOS extension code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
diff --git a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc b/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
index 402fd650ac2bd3d9c55cc1dbd9b399f232e32d35..ddd681e5c7421ee56ebfa834a66dd0fb57ecd592 100644
--- a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
+++ b/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h"
#include <string>
+#include <utility>
#include <vector>
#include "base/memory/linked_ptr.h"
@@ -283,8 +284,9 @@ bool FileSystemProviderInternalUnmountRequestedSuccessFunction::RunWhenValid() {
scoped_ptr<Params> params(Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params);
- return FulfillRequest(RequestValue::CreateForUnmountSuccess(params.Pass()),
- false /* has_more */);
+ return FulfillRequest(
+ RequestValue::CreateForUnmountSuccess(std::move(params)),
+ false /* has_more */);
}
bool
@@ -294,7 +296,7 @@ FileSystemProviderInternalGetMetadataRequestedSuccessFunction::RunWhenValid() {
EXTENSION_FUNCTION_VALIDATE(params);
return FulfillRequest(
- RequestValue::CreateForGetMetadataSuccess(params.Pass()),
+ RequestValue::CreateForGetMetadataSuccess(std::move(params)),
false /* has_more */);
}
@@ -304,8 +306,9 @@ bool FileSystemProviderInternalGetActionsRequestedSuccessFunction::
scoped_ptr<Params> params(Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params);
- return FulfillRequest(RequestValue::CreateForGetActionsSuccess(params.Pass()),
- false /* has_more */);
+ return FulfillRequest(
+ RequestValue::CreateForGetActionsSuccess(std::move(params)),
+ false /* has_more */);
}
bool FileSystemProviderInternalReadDirectoryRequestedSuccessFunction::
@@ -317,7 +320,7 @@ bool FileSystemProviderInternalReadDirectoryRequestedSuccessFunction::
const bool has_more = params->has_more;
return FulfillRequest(
- RequestValue::CreateForReadDirectorySuccess(params.Pass()), has_more);
+ RequestValue::CreateForReadDirectorySuccess(std::move(params)), has_more);
}
bool
@@ -329,8 +332,8 @@ FileSystemProviderInternalReadFileRequestedSuccessFunction::RunWhenValid() {
EXTENSION_FUNCTION_VALIDATE(params);
const bool has_more = params->has_more;
- return FulfillRequest(RequestValue::CreateForReadFileSuccess(params.Pass()),
- has_more);
+ return FulfillRequest(
+ RequestValue::CreateForReadFileSuccess(std::move(params)), has_more);
}
bool
@@ -341,7 +344,7 @@ FileSystemProviderInternalOperationRequestedSuccessFunction::RunWhenValid() {
return FulfillRequest(
scoped_ptr<RequestValue>(
- RequestValue::CreateForOperationSuccess(params.Pass())),
+ RequestValue::CreateForOperationSuccess(std::move(params))),
false /* has_more */);
}
@@ -351,7 +354,7 @@ bool FileSystemProviderInternalOperationRequestedErrorFunction::RunWhenValid() {
EXTENSION_FUNCTION_VALIDATE(params);
const base::File::Error error = ProviderErrorToFileError(params->error);
- return RejectRequest(RequestValue::CreateForOperationError(params.Pass()),
+ return RejectRequest(RequestValue::CreateForOperationError(std::move(params)),
error);
}

Powered by Google App Engine
This is Rietveld 408576698