chrome/browser/extensions/api/platform_keys/platform_keys_api.cc - Issue 1556783002: Convert Pass()→std::move() for CrOS extension code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

Issue 1556783002: Convert Pass()→std::move() for CrOS extension code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc ('k') | chrome/browser/extensions/api/settings_private/prefs_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

diff --git a/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc b/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

index e683c0566f97364fa30230843e2c1f2cc28788a0..65e143e00a672dc1c73f4f04b60bf18a4350abf0 100644

--- a/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

+++ b/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

@@ -5,7 +5,7 @@

#include "chrome/browser/extensions/api/platform_keys/platform_keys_api.h"

#include <stddef.h>

+#include <utility>

#include <vector>

#include "base/bind.h"

@@ -229,7 +229,8 @@ PlatformKeysInternalSelectClientCertificatesFunction::Run() {

}

service->SelectClientCertificates(

- request, client_certs.Pass(), params->details.interactive, extension_id(),

+ request, std::move(client_certs), params->details.interactive,

+ extension_id(),

base::Bind(&PlatformKeysInternalSelectClientCertificatesFunction::

OnSelectedCertificates,

this),

@@ -353,7 +354,7 @@ PlatformKeysVerifyTLSServerCertificateFunction::Run() {

VerifyTrustAPI::GetFactoryInstance()

->Get(browser_context())

- ->Verify(params.Pass(), extension_id(),

+ ->Verify(std::move(params), extension_id(),

base::Bind(&PlatformKeysVerifyTLSServerCertificateFunction::

FinishedVerification,

this));